Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update: hr within select element #504

Merged
merged 4 commits into from
Oct 9, 2023
Merged

Update: hr within select element #504

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ac445f2
Update: hr within select element
scottaohara Oct 3, 2023
ed8dacc
Merge branch 'gh-pages' into hr-select
scottaohara Oct 6, 2023
3c52dea
Merge branch 'gh-pages' into hr-select
scottaohara Oct 9, 2023
656f7da
update change log
scottaohara Oct 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2792,6 +2792,7 @@ <h4 id=el-hr>`hr`</h4>
<tr>
<th>Comments</th>
<td>
<p>If an `hr` element is a descendant of a `select` element, user agents MAY expose the element with a role of `none`.</p>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the standard list separator behavior in Mac, and it's also a MAY, so probably okay to approve without requiring input from Chrome, Edge, and Gecko, but as a courtesy, we should request input from @aleventhal @benbeaudry and @jcsteh

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For clarity, my @ mention above counts as that courtesy request. @scottaohara if you don't hear back in a week and have a second approval, please merge.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good to me. +1

</td>
</tr>
</tbody>
Expand Down
Loading