Update ARIA mappings for various meter and input related attributes #244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While the `meter` role will be defined in ARIA 1.2, the attribute mappings for `min` and `max` are availalbe now, so we should point to those. This commit also updates the HTML attr links for these attributes. Additionally, ARIA 1.2 notes that an attribute for `low`, `high` and `optimum` will not be made until ARIA 1.3, if at all. Those HTML attribute ARIA mappings have also been updated as necessary.
scottaohara
changed the title
stevefaulkner
approved these changes
Sep 23, 2019
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While the
meterrole will be defined in ARIA 1.2, the attribute mappings forminandmaxare availalbe now, so we should point to those.This commit also updates the HTML attr links for these attributes.
Additionally, ARIA 1.2 notes that an attribute for
low,highandoptimumwill not be made until ARIA 1.3, if at all. Those HTML attribute ARIA mappings have also been updated as necessary.@stevefaulkner, @joanmarie do either of you have any reason to think we should wait to merge these changes until
role=meterofficially lands? Also, I was thinking we can just trim down the other cell entries to "Use WAI-ARIA mapping", unless you think there's value in keeping the "if the element implements the interface" text that's currently in the table cells. Thoughts?Related to issue #229 and #97
The following tasks have been completed:
Preview | Diff