-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix #743] Change --version and -version options to output EpubCheck version #841
Conversation
Looks good to me. Very straightforward. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally OK to me (thank you!). A couple things however before merging:
The following help text should be updated in message.properties
:
version_argument_expected=Version number omitted from the -version argument.
Also, as @kalaspuffar said suggested, could you please add a unit test?
I'll get to the requested changes this weekend. |
…o mention option -v instead of -version
I added command line unit tests for version and help. |
Looks good to me, thank you @kamorrissey! 👍 |
All changes approved, awesome! :) I suggest we ship this with 4.1 and I'm going to merge it to master in a couple of hours, are you all okay with that? |
Merged. Thanks a lot @kamorrissey! 👏 🎉 Looking forward to seeing more contributions from you! 👍 |
A minimal set of changes to repurpose the "--version" and "-version" command line options to output the EpubCheck program version instead of being undocumented synonyms for the "-v" option. Made sure to update the --help message.