Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix #743] Change --version and -version options to output EpubCheck version #841

Merged
merged 2 commits into from
May 2, 2018

Conversation

kamorrissey
Copy link
Contributor

A minimal set of changes to repurpose the "--version" and "-version" command line options to output the EpubCheck program version instead of being undocumented synonyms for the "-v" option. Made sure to update the --help message.

@kalaspuffar
Copy link
Contributor

kalaspuffar commented Apr 26, 2018

Looks good to me. Very straightforward.
I'm not sure if it's required, but there is a class for testing command line features (com.adobe.epubcheck.cli.CLITest)
So a unit test could be crafted for this flag.

Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks generally OK to me (thank you!). A couple things however before merging:

The following help text should be updated in message.properties :

version_argument_expected=Version number omitted from the -version argument.

Also, as @kalaspuffar said suggested, could you please add a unit test?

@tofi86 tofi86 mentioned this pull request Apr 26, 2018
@tofi86 tofi86 added the type: improvement The issue suggests an improvement of an existing feature label Apr 26, 2018
@tofi86 tofi86 added this to the 4.1.0 milestone Apr 26, 2018
@kmorrissey-mersive
Copy link

I'll get to the requested changes this weekend.

@kamorrissey
Copy link
Contributor Author

I added command line unit tests for version and help.

@rdeltour
Copy link
Member

Looks good to me, thank you @kamorrissey! 👍

@tofi86 tofi86 changed the title Change --version and -version options to output EpubCheck version [fix #743] Change --version and -version options to output EpubCheck version Apr 27, 2018
@tofi86
Copy link
Collaborator

tofi86 commented Apr 27, 2018

All changes approved, awesome! :)

I suggest we ship this with 4.1 and I'm going to merge it to master in a couple of hours, are you all okay with that?

@tofi86 tofi86 merged commit e498c61 into w3c:master May 2, 2018
@tofi86
Copy link
Collaborator

tofi86 commented May 2, 2018

Merged. Thanks a lot @kamorrissey! 👏 🎉

Looking forward to seeing more contributions from you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants