Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update messages_es.properties #592

Closed
wants to merge 1 commit into from
Closed

Conversation

Cuadratin
Copy link
Contributor

No description provided.

@tofi86 tofi86 mentioned this pull request Sep 9, 2015
7 tasks
@rdeltour
Copy link
Member

rdeltour commented Sep 9, 2015

Thx @Cuadratin ! 👍

There are a few additions and changes in regular error messages too (MessageBundle.properties files). Not sure how to proceed exactly, e.g. if it's preferable to use Transifex (see #479). @tofi86 any help?

@tofi86
Copy link
Collaborator

tofi86 commented Sep 9, 2015

Yeah, I was wondering, too, how to handle the translations... You remember this was one of my concerns in #479? ;-) Well...

Transifex still syncs the english property files with the master branch, so I expect this information to be up-to-date: https://www.transifex.com/idpf/epubcheck/
Okay, I see there has been a problem in syncing the english strings, I've updated the resources manually and re-enabled the auto-sync.
Also added new properties file https://github.com/IDPF/epubcheck/blob/master/src/main/resources/com/thaiopensource/validate/schematron/resources/Messages.properties

Alright @Cuadratin, Transifex is up-to-date and with a Transifex account you're able to either translate the spanish strings in their webapp or identify the changed/new strings and add them to your PullRequest.

@Cuadratin
Copy link
Contributor Author

OK, @tofi86 I'll check Transifex and update the spanish translations there.

Thanks.

@tofi86
Copy link
Collaborator

tofi86 commented Sep 9, 2015

@Cuadratin when translating messages, especially in com/adobe/epubcheck/messages/MessageBundle.properties, make sure you have the History tab opened on the right in Transifex so you can see previous translations for the current message.

bildschirmfoto 2015-09-09 um 23 19 34

This is useful in case @rdeltour only changed a word in the message but not the whole message itself...

@tofi86 tofi86 added this to the Next milestone Sep 10, 2015
@tofi86
Copy link
Collaborator

tofi86 commented Sep 26, 2015

@Cuadratin Emiliano, thanks for the translations on Transifex. I cleaned up the Transifex properties files and built a zip file with your changes: https://www.dropbox.com/s/1bncwvpl0ovxqwy/transifex_properties_es.zip?dl=1

Download the zip, unpack it in your epubcheck repo on your PullRequest branch (overwrite this change) and commit the changes as a new commit. I'll take care of the rest, okay?

The cleaning of the Transifex files should also solve the issues with accented characters from ticket #482...

@Cuadratin
Copy link
Contributor Author

Hi @tofi86

I think I've done the steps you told me. I've tried with Github Desktop for OSX, since I barely know how to use Github at all.

If there's something wrong let me know.

Thanks

@tofi86 tofi86 mentioned this pull request Sep 28, 2015
@tofi86
Copy link
Collaborator

tofi86 commented Sep 28, 2015

@Cuadratin sorry, this didn't work out as you deleted ALL other source files on the new PullRequest #611 😏
You should have switched to your patch-5 branch which represents this PullRequest and unpack the zip file without deleting all other files...

I'll go and open a new PulLRequest with your changes. Stay tuned.

@tofi86 tofi86 closed this Sep 28, 2015
@Cuadratin
Copy link
Contributor Author

Sorry very much. Github is totally unknown for me and it's a mess all these branches, commits, pull requests… :(

Tell me if I must upload anything or change whatever.

@tofi86
Copy link
Collaborator

tofi86 commented Sep 28, 2015

Sorry very much. Github is totally unknown for me and it's a mess all these branches, commits, pull requests… :(

No worries, we've all been there ;-)
I committed your translations in the new PR #612 and discussion about the translation should go on there.
If I can help you with GitHub or in understanding Git in some point, just write me a private email.... :-)

@tofi86 tofi86 modified the milestones: Next, 4.0.1 Sep 30, 2015
tofi86 pushed a commit that referenced this pull request Oct 2, 2015
@tofi86 tofi86 self-assigned this Oct 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants