feat: check that the manifest is not self-referencing #1467

rdeltour · 2022-12-23T17:33:06Z

This commit adds a new check, reported as OPF-099 (error), to verify that the package document manifest does not include an item element that refers to the package document itself.

This statement was apparently not checked by EPUBCheck previously. Worse, the code was entering an infinite loop, as the package document checker was creating a new checker for itself, recursively.

Fix #1453

mattgarrish · 2023-01-03T13:11:23Z

src/main/resources/com/adobe/epubcheck/messages/MessageBundle.properties

@@ -215,6 +215,7 @@ OPF_096=Non-linear content must be reachable, but found no hyperlink to "%1$s".
 OPF_096b=No hyperlink was found to non-linear document "%1$s", please check that it can be reached from scripted content.
 OPF_097=Resource "%1$s" is listed in the manifest, but no reference to it was found in content documents.
 OPF_098=The "href" attribute must not reference resources via elements in the package document itself, but found URL "%1$s".
+OPF_099=The package document must not include itself in its manifest. 


A minor clarity suggestion:

Suggested change

OPF_099=The package document must not include itself in its manifest.

OPF_099=The manifest must not list the package document .

This commit adds a new check, reported as `OPF-099` (error), to verify that the package document `manifest` does not include an `item` element that refers to the package document itself. This statement was apparently not checked by EPUBCheck previously. Worse, the code was entering an infinite loop, as the package document checker was creating a new checker for itself, recursively. Fix #1453

--------------------- Add `plaintext-only` value to `contenteditable` attribute validator/validator@228ea687b Co-authored-by: Niedziolka Michal <[email protected]> --------------------- add warnings for deprecated ARIA attributes (#1560) validator/validator@e61fbeb2c Co-authored-by: Steve Faulkner <[email protected]> --------------------- disallow aria attributes on datalist (#1557) validator/validator@b4849c04b Co-authored-by: Steve Faulkner <[email protected]> --------------------- allow role=button on area validator/validator@89ff1fc2b Co-authored-by: stevefaulkner <[email protected]> --------------------- fix: allow -1 for aria-colcount validator/validator@2466e73c4 Co-authored-by: Nick Schonning <[email protected]> --------------------- fix: Allow -1 for aria-rowcount validator/validator@eac205b6b Co-authored-by: Nick Schonning <[email protected]> --------------------- Add `fetchpriority` attribute validator/validator@7c9991405 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- Script type importmap (#1478) validator/validator@4054c56f5 Co-authored-by: Michał Niedziółka <[email protected]> --------------------- Move “manifest” attribute to legacy-attributes list validator/validator@175e62d3a Co-authored-by: Michael[tm] Smith <[email protected]> --------------------- Pointer Events (#1481) validator/validator@5eb52a931 Co-authored-by: Michał Niedziółka <[email protected]> --------------------- Report a better error message for obsolete “manifest” attribute validator/validator@ae924b625 Co-authored-by: Michael[tm] Smith <[email protected]> --------------------- onscrollend validator/validator@87287a97f Co-authored-by: Niedziolka Michal <[email protected]> --------------------- slot element validator/validator@d6cf423c1 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- Allow paragraphs in hgroup (#1467) validator/validator@3ff53973f Co-authored-by: Michał Niedziółka <[email protected]> --------------------- blocking="render" (#1466) validator/validator@df5d4e23a Co-authored-by: Michał Niedziółka <[email protected]> --------------------- inert validator/validator@507f551b2 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- hidden=until-found validator/validator@a424d55a8 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- media attribute in meta element validator/validator@af3e94d22 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- Sync event handlers validator/validator@58bea51c7 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- Remove manifest attribute validator/validator@66510f3ca Co-authored-by: Niedziolka Michal <[email protected]> --------------------- enterkeyhint validator/validator@70f3044d7 Co-authored-by: Niedziolka Michal <[email protected]> --------------------- Form method dialog (#1443) validator/validator@0db229a44 Co-authored-by: Michał Niedziółka <[email protected]> --------------------- imagesrcset and imagesizes in link (#1444) validator/validator@49656dbfc Co-authored-by: Michał Niedziółka <[email protected]> --------------------- feat: add support width and height of source in picture validator/validator@176d98e4f Co-authored-by: Takeshi Kurosawa <[email protected]> --------------------- Update: allow none/presentation on nav element (#1323) validator/validator@5e25edb39 Co-authored-by: Scott O'Hara <[email protected]> --------------------- Update schema/html5/web-forms.rnc validator/validator@95ba6c7cf Co-authored-by: Michael[tm] Smith <[email protected]> --------------------- update role allowances for button and input type=button validator/validator@6cc14c4d7 Co-authored-by: Scott O'Hara <[email protected]> --------------------- adds role=radio alowance to img alt=foo validator/validator@b013aa02b Co-authored-by: Scott O'Hara <[email protected]> --------------------- remove deprecated dpub role allowances validator/validator@b0fb152c0 Co-authored-by: Scott O'Hara <[email protected]> --------------------- allow section element to have role=group validator/validator@078341d37 Co-authored-by: Scott O'Hara <[email protected]>

rdeltour added this to the v5.0.0-rc milestone Dec 23, 2022

rdeltour requested a review from mattgarrish December 23, 2022 17:33

rdeltour self-assigned this Dec 23, 2022

mattgarrish reviewed Jan 3, 2023

View reviewed changes

mattgarrish approved these changes Jan 3, 2023

View reviewed changes

rdeltour force-pushed the feat/package-links branch 2 times, most recently from aaed7bb to 54b5f1f Compare January 3, 2023 14:31

Base automatically changed from feat/package-links to main January 3, 2023 14:32

rdeltour force-pushed the feat/manifest-self-reference branch from db0d027 to c2fab31 Compare January 3, 2023 14:36

rdeltour force-pushed the feat/manifest-self-reference branch from c2fab31 to 2c76420 Compare January 3, 2023 14:36

rdeltour merged commit 2c76420 into main Jan 3, 2023

rdeltour deleted the feat/manifest-self-reference branch January 3, 2023 14:37

rdeltour mentioned this pull request Jul 6, 2023

feat: update to latest schemas from the Nu HTML Checker #1530

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: check that the manifest is not self-referencing #1467

feat: check that the manifest is not self-referencing #1467

rdeltour commented Dec 23, 2022

mattgarrish Jan 3, 2023

	OPF_099=The package document must not include itself in its manifest.
	OPF_099=The manifest must not list the package document .

feat: check that the manifest is not self-referencing #1467

feat: check that the manifest is not self-referencing #1467

Conversation

rdeltour commented Dec 23, 2022

mattgarrish Jan 3, 2023

Choose a reason for hiding this comment