feat: no longer check collection role
#1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit suppresses and removes the code of the following checks: - `OPF-068`: checked that a role token were one the defined roles in the collection role registry (see https://idpf.github.io/epub-registries/roles/) - `OPF-069`: checked that a custom role URL did not contain the string "idpf.org". These restrictions were removed in EPUB 3.3. The attribute value is still tokenized, and any URL-looking string (in the shape `scheme:something`) is checked to be a valid URL string. Fix #1350.
mattgarrish
approved these changes
Dec 5, 2022
There was a problem hiding this comment.
The comments in the test file are a bit misleading - nothing has changed about how collection roles are validated between 3.2 and 3.3. You don't have to maintain the 3.2 rules anymore as no one uses these anyway, but it's more that collections are being abandoned without deprecating than anything about them has changed.
|
Right. I clarified the comments in #1447 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR suppresses and removes the code of the following checks:
OPF-068: checked that a role token were one the defined roles inthe collection role registry
(see https://idpf.github.io/epub-registries/roles/)
OPF-069: checked that a custom role URL did not contain the string"idpf.org".
These restrictions were removed in EPUB 3.3.
The attribute value is still tokenized, and any URL-looking string
(in the shape
scheme:something) is checked to be a valid URL string.Fix #1350.