Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: better check media overlays styling properties #1402

Merged
merged 1 commit into from
Dec 5, 2022
Merged

feat: better check media overlays styling properties #1402

merged 1 commit into from
Dec 5, 2022

Conversation

rdeltour
Copy link
Member

@rdeltour rdeltour commented Dec 2, 2022

  • report schema error RSC-005 when the 'media:active-class' or 'media:playback-active-class' properties are declared more than once.
  • report schema error RSC-005 when the 'media:active-class' or 'media:playback-active-class' properties define more than once class names.
  • report new usage CSS-029 when a CSS selector is found referring to the widely-used '-epub-media-overlay-active' or '-epub-media-overlay- playing' class names but no 'media:active-class' or 'media:playback- active-class' properties were declared in the package document.
  • report new error CSS-030 when the 'media:active-class' or 'media:playback-active-class' properties are declared but no CSS is found in a content document with media overlays.
  • added various test scenarios for the checks described above.

Closs #1218.

@rdeltour
feat: better check media overlays styling properties
6a58b8e 
- report schema error RSC-005 when the 'media:active-class' or
  'media:playback-active-class' properties are declared more than once.
- report schema error RSC-005 when the 'media:active-class' or
  'media:playback-active-class' properties define more than once class
  names.
- report new usage CSS-029 when a CSS selector is found referring to
  the widely-used '-epub-media-overlay-active' or '-epub-media-overlay-
  playing' class names but no 'media:active-class' or 'media:playback-
  active-class' properties were declared in the package document.
- report new error CSS-030 when the 'media:active-class' or
  'media:playback-active-class' properties are declared but no CSS is
  found in a content document with media overlays.
- added various test scenarios for the checks described above.

Closs #1218.
@rdeltour rdeltour added this to the v5.0.0-beta milestone Dec 2, 2022
@rdeltour rdeltour requested a review from mattgarrish December 2, 2022 10:52
@rdeltour rdeltour self-assigned this Dec 2, 2022
Base automatically changed from feat/meta-viewport-syntax to release/v5.0.0 December 5, 2022 13:08
@rdeltour rdeltour merged commit 6a58b8e into release/v5.0.0 Dec 5, 2022
@rdeltour rdeltour deleted the feat/overylays-styling-checks branch December 5, 2022 13:08
@rdeltour rdeltour mentioned this pull request Dec 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattgarrish mattgarrish mattgarrish approved these changes

Assignees

@rdeltour rdeltour

Labels
None yet
Projects
None yet
Milestone
v5.0.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@rdeltour @mattgarrish