fix: do not require the Navigation Document to have an index #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dex Publication This fix removes the index-specific schemas when checking the Navigation Document. It is probably too simple, a better implementation would only do so if the Nav Doc is not in the spine or is not the only Content Document in the spine, but there is no easy way to check that latter condition in the NavChecker. The fix is a reasonable compromise, as a false-negative (the Nav Doc **must** have index content when it is the unique Content Document) should be pretty rare, and is always better than a false-positive. Fixes #1122
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix removes the index-specific schemas when checking the Navigation
Document.
It is probably too simple, a better implementation would only do so if
the Nav Doc is not in the spine or is not the only Content Document in
the spine, but there is no easy way to check that latter condition in
the NavChecker.
The fix is a reasonable compromise, as a false-negative (the Nav Doc
must have index content when it is the unique Content Document) should
be pretty rare, and is always better than a false-positive.
Fixes #1122