Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an Automatic-Module-Name #1129

Merged
merged 1 commit into from
May 1, 2020
Merged

Conversation

io7m
Copy link
Contributor

@io7m io7m commented Apr 19, 2020

This adds an Automatic-Module-Name manifest entry in order to allow
epubcheck to be used in a modular context without having to depend
on an unstable generated module name.

Fix: #1128

This adds an Automatic-Module-Name manifest entry in order to allow
epubcheck to be used in a modular context without having to depend
on an unstable generated module name.

Fix: w3c#1128
@rdeltour rdeltour self-requested a review May 1, 2020 08:41
@rdeltour rdeltour self-assigned this May 1, 2020
@rdeltour rdeltour added this to the 4.2.3 milestone May 1, 2020
Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK to me! The suggested module name matches the OSGi Bundle Name 👍

@rdeltour rdeltour merged commit ee06724 into w3c:master May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Any chance you could add an Automatic-Module-Name?
2 participants