Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix #1097] downgrade PKG-012 (filename contains non-ASCII) from WARNING to USAGE #1099

Closed
wants to merge 1 commit into from
Closed

[fix #1097] downgrade PKG-012 (filename contains non-ASCII) from WARNING to USAGE #1099

wants to merge 1 commit into from

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@slonopotamus slonopotamus force-pushed the PKG-012-not-a-warning branch from bc110bc to d86f03f Compare January 23, 2020 20:12
@slonopotamus slonopotamus mentioned this pull request Jan 23, 2020
Closed
@slonopotamus slonopotamus force-pushed the PKG-012-not-a-warning branch 4 times, most recently from 81a35dd to 12ffbc1 Compare January 24, 2020 07:43
@slonopotamus slonopotamus force-pushed the PKG-012-not-a-warning branch from 12ffbc1 to 4fa7d31 Compare January 24, 2020 07:51
@slonopotamus slonopotamus requested a review from rdeltour January 25, 2020 15:46
@rdeltour rdeltour self-assigned this Jan 27, 2020
@rdeltour rdeltour added status: needs review Needs to be reviewed by a team member before further processing type: improvement The issue suggests an improvement of an existing feature labels Jan 27, 2020
@rdeltour rdeltour added this to the 4.2.3 milestone Jan 27, 2020
@rdeltour
Copy link
Member

rdeltour commented Apr 30, 2020 •
edited
Loading

(edited to take the discussion on the related issue #1097 instead)

@rdeltour rdeltour added status: ready to merge The pull request is ready to be merged and removed status: needs review Needs to be reviewed by a team member before further processing labels Apr 30, 2020
rdeltour
rdeltour approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@rdeltour rdeltour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving the PR, after the positive comments in #1097.

Thanks for the contribution @slonopotamus! 🎉

@rdeltour
Copy link
Member

Rebased and merged as f368ee5

@rdeltour rdeltour closed this Apr 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdeltour rdeltour rdeltour approved these changes

Assignees

@rdeltour rdeltour

Labels
status: ready to merge The pull request is ready to be merged type: improvement The issue suggests an improvement of an existing feature
Projects
None yet
Milestone
4.2.3
Development

Successfully merging this pull request may close these issues.
2 participants
@slonopotamus @rdeltour