-
Notifications
You must be signed in to change notification settings - Fork 407
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
role="doc-pagebreak"
rejected on a
element with no href
attribute
#1022
Comments
This seems to be a bug in the schemas, as I'll look into it! |
role="doc-pagebreak"
rejected on a
element with no href
attribute
In the meantime, I'd recommend using a neutral element like a |
Apparently this was reported already as validator/validator#638, which is marked as wontfix. Quoting the issue here for convenience:
We now have to gauge whether this is problematic for EPUB and if we can reasonably provide a patch, or if we can just follow the lead and mark it as |
My inclination is to leave it as an error to apply non-link roles on |
And in case it needs saying, I also can't see this being the compelling use case that gets a patch accepted. |
Yeah I just submitted a PR to fix that in the Nu HTML Checker 😅 (evening fun). Anyways, whether this might or might not be a compelling case has to do with how widespread the practice of using |
Btw, using I asked on Twitter and letex folks said:
|
Well, we shouldn't start pushing to legitimize the uses of ARIA in HTML isn't a recommendation at this point, though, so it'll be interesting to see how this plays out. We may not want to prematurely legitimize practices that won't survive. |
Now you make me feel bad about submitting that PR 😬😅 Joke aside, what we would really need is:
|
All I meant is we probably shouldn't rush to support this in epubcheck. If it doesn't make the coming release, so be it. Better to be late to the party than get it wrong.
Given that we've always promoted pagebreaks through epub:type, I'd suspect very little. There's also no reason to rush people to roles at this point, but that's maybe something we should reconsider in Ace. We probably should tone down the messaging that every epub:type needs a role, and reconsider the elements we should even be considering equivalency on. |
Good practices in EPUB world have been specified as: IMO, using an |
SR users can browse from link to link. Tests with 2
Note: |
The original reporter stated, that they were always using |
There also isn't a rush to changeover. For the most part, they're just destinations to jump to, with the possibility to provide visual indicators in reading systems (though I don't think many actually do). The page list has always been the more important piece. The announcing of page breaks is partly predicated on the ability to turn off such announcements, as they are disruptive to immersive reading. Making them ARIA roles effectively turns them on to be announced (when AT do begin supporting DPUB roles), but doesn't leave much control for turning them off. |
FYI: So currently on the DAISY KB there is the following: Can I use a tags for page numbers? Does this need to be adjusted? |
No, the KB is on point: That ARIA in HTML allow any role on |
My PR validator/validator#774 has been merged, so the Nu HTML Checker is now aligned with the spec and will no longer reject the I'll create a PR to port the schema fix to EPUBCheck. |
Any role is allowed according to ARIA in HTML: https://www.w3.org/TR/html-aria/#anohref Ported from validator/validator#774 Fix #1022
A pagina EPUB-Check user is reporting the following issue with 4.2.0-rc:
HTML:
EPUBCheck report:
According to https://idpf.github.io/epub-guides/epub-aria-authoring/ should be tagged with
<hr>
but:What's wrong here?
The text was updated successfully, but these errors were encountered: