Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposed changes to EPUB 3.3 and EPUB RS 3.3 to support Webtoons #2602

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
61 changes: 61 additions & 0 deletions epub33/core/images/example_rendering_FXL_scrolled_continuous.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
86 changes: 86 additions & 0 deletions epub33/core/images/example_rendering_FXL_scrolled_doc.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
11 changes: 11 additions & 0 deletions epub33/core/images/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,20 @@ Here is the link to the individual files:
- [example_spread_landscape.svg](https://docs.google.com/drawings/d/1d1Q-pjutZFl09FSx-P5Hl_TswiiuW_jTX4lqv47PVfQ/edit?usp=drive_link)
- [example_spread_none.svg](https://docs.google.com/drawings/d/1uJVY_IkZwWiz3Tux3WfqStfA8cNTbF4jBzHFz84ir7A/edit?usp=drive_link)
- [example_spread_page_spread_right.svg](https://docs.google.com/drawings/d/1rTwzPcksrs0xPMQPIh3bAMkkt9zV9XUChzCJ2pWjnF8/edit?usp=drive_link)
- [example_rendering_FXL_paginated_multiple_spine.svg](https://docs.google.com/drawings/d/13vh7wpr11bddJ-HilCq04WnkaRbr_ixaAPzx2YN0wtI/edit?usp=sharing)
- [example_rendering_FXL_scrolled_doc.svg](https://docs.google.com/drawings/d/1QP_Iea9-_e60qqz1sbLfQ9AMEFRhCBi2qUMqYNJwjgg/edit?usp=sharing)
- [example_rendering_FXL_scrolled_continuous.svg](https://docs.google.com/drawings/d/1EE98CX1LuAQcTIXe5JMSahU-TwgWXeOmADppe5_48mc/edit?usp=sharing)


All files should be publicly visible and can be commented upon. If there is any access issue, please contact [Ivan Herman]([email protected]).

The workflow for adding these to the document is as follows:

- Create/modify the drawing on Google Doc
- Export the content into SVG
- Modify the SVG file:
- The `viewBox` attribute should be modified to make it as close to the "real" content as possible, otherwise too much empty space is left in the final document. Unfortunately, this is pretty much a trial-and-error process. (A good trick: add, temporarily, a `<rect x="0" y="0", width={viewBox width} height={viewBox height} fill="yellow"/>` at the very beginning of the file and then play with the rectangle dimension to find the smallest enclosing rectangle for the content. That will set the final `viewBox` values.)
- If your editor has a formatting possibility it may be useful to run it; it may help others to possibly consult the SVG content
- Add a reference via an `<image>` element to the SVG file. The `width` argument may have to be modified to make the drawing appear on a proper size in the document.


Loading