Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restriction on epub:type in svg is too strict #2556

Closed
mattgarrish opened this issue Apr 24, 2023 · 1 comment · Fixed by #2574
Closed

Restriction on epub:type in svg is too strict #2556

mattgarrish opened this issue Apr 24, 2023 · 1 comment · Fixed by #2574
Assignees
@iherman
Labels
Change-Class-3 Requested changes are of class 3 (per process) EPUB33 Issues addressed in the EPUB 3.3 revision Errata Item accepted as an official errata for one or several specs Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Topic-ContentDocs The issue affects EPUB content documents

Comments

@mattgarrish
Copy link
Member

As reported in w3c/epubcheck#1497, the current restriction on epub:type in svg content documents does not allow the attribute on a elements.

The definition of renderable elements is probably a better alternative than the three categories listed.

(If the current three categories are kept, however, note that they link to the svg 1.1 specification so should be updated.)
@mattgarrish mattgarrish added Topic-ContentDocs The issue affects EPUB content documents Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation labels Apr 24, 2023
@iherman iherman added the ErratumRaised Raise an erratum, not yet accepted by the maintainers. label Apr 24, 2023
rdeltour added a commit to w3c/epubcheck that referenced this issue Apr 28, 2023
@rdeltour
feat: allow epub:type on SVG renderable elements
6cd9789 
Update the SVG schemas to allow the "epub:type" attribute on all renderable elements, as suggested in w3c/epub-specs#2556.

Note: this is a willful violation of the EPUB 3.3 spec, which (at the time of writing) only allows the attribute on structural, shape, and text elements.

Fix #1497
@rdeltour rdeltour mentioned this issue Apr 28, 2023
Merged
@iherman iherman self-assigned this May 15, 2023
@iherman
Copy link
Member

iherman commented Jul 11, 2023

This, imho, a valid erratum, and could be marked as such. Definitely a class 3...

@TzviyaSiegman @shiestyle @dauwhe @wareid

@iherman iherman added the Change-Class-3 Requested changes are of class 3 (per process) label Jul 18, 2023
This was referenced Jul 21, 2023
Closed
Merged
@iherman iherman added Errata Item accepted as an official errata for one or several specs and removed ErratumRaised Raise an erratum, not yet accepted by the maintainers. labels Aug 4, 2023
@mattgarrish mattgarrish added the EPUB33 Issues addressed in the EPUB 3.3 revision label Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iherman iherman

Labels
Change-Class-3 Requested changes are of class 3 (per process) EPUB33 Issues addressed in the EPUB 3.3 revision Errata Item accepted as an official errata for one or several specs Spec-EPUB3 The issue affects the core EPUB 3.3 Recommendation Topic-ContentDocs The issue affects EPUB content documents
Projects
None yet
Milestone
No milestone
2 participants
@iherman @mattgarrish