Add note that updateText can have rangeStart > rangeEnd #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snianu
approved these changes
Feb 13, 2024
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 15, 2024
Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 16, 2024
Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301307 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261748}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 16, 2024
Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301307 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261748}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Feb 23, 2024
…ms in updateText, a=testonly Automatic update from web-platform-tests [EditContext] Allow backwards range params in updateText Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301307 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261748} -- wpt-commits: 86be793cf4c65625e241ac179ad3093981832779 wpt-pr: 44616
marcoscaceres
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Feb 23, 2024
Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301307 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261748}
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
Feb 24, 2024
…ms in updateText, a=testonly Automatic update from web-platform-tests [EditContext] Allow backwards range params in updateText Per w3c/edit-context#90, EditContext.updateText() should allow the start/end parameters to be backwards. Bug: 40642681 Change-Id: Idde01fa7282120e0961eb60a9ccab58061f4062b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5301307 Reviewed-by: Anupam Snigdha <[email protected]> Reviewed-by: Koji Ishii <[email protected]> Commit-Queue: Dan Clark <[email protected]> Cr-Commit-Position: refs/heads/main@{#1261748} -- wpt-commits: 86be793cf4c65625e241ac179ad3093981832779 wpt-pr: 44616
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #81, add note clarifying that updateStart() can have updateRangeStart > updateRangeEnd.
Replace old note that doesn't seem to apply anymore.
Closes #81