-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should the methods of EditContext throw an exception if they abort due to not activated? #26
Comments
This is an old issue but the question is still relevant, and we should prioritize resolving it. There's a third option I'd also like to consider, which is that we could just let the methods run normally even if the EditContext is not active. I think that is actually the more desirable behavior. Consider a page with multiple editable forms each implemented with EditContext, and the page has a single button to clear all forms. The page should not be required to set focus on each form in order to clear its text state. The implementations of these methods don't fire any events, they're just a state update. So allowing them to function on a non-active EditContext should not introduce any complications. |
Bot posted the minutes from the wrong topic. Here are the correct minutes from the 2023-10-12 WG meeting:
|
Per [WG resolution](#26 (comment)), remove "is active" checks from `updateText()`, `updateSelection()`, `updateSelectionBounds()`, `updateControlBounds()`, and `updateCharacterBounds()`. Closes #26
The methods of
EditContext
are defined their behavior asBut this is unclear whether an exception should be thrown or silently do nothing.
The text was updated successfully, but these errors were encountered: