Fix editorial and substantive issues in JSON Production and Consumption section. #653
Conversation
msporny
changed the title
msporny
requested review from
brentzundel,
dlongley,
jricher,
OR13 and
peacekeeper
index.html
Outdated
| additional processing applied to its value, which will be added verbatim to the | ||
| <a href="#data-model">data model</a>. | ||
| If media type information is available to a <a>conforming consumer</a> and the | ||
| media type value is <code>application/did+json</code>, the data structure being |
There was a problem hiding this comment.
| media type value is <code>application/did+json</code>, the data structure being | |
| media type value is <code>application/did+json</code>: the data structure being |
There was a problem hiding this comment.
I think this change would be an error. See mine below. https://github.com/w3c/did-core/pull/653/files?diff=unified&w=1#r577047614
There was a problem hiding this comment.
Applied change from @TallTed.
index.html
Outdated
| member of the JSON object. The values of entries, | ||
| including all extensions, are encoded in JSON [[RFC8259]] by mapping entry | ||
| values to JSON types as follows: | ||
| All data structures expressed by the <a href="#data-model">data model</a> |
There was a problem hiding this comment.
This change https://github.com/w3c/did-core/pull/653/files#r577646064 implements https://www.w3.org/2021/02/16-did-topic-minutes.html#r01. @peacekeeper, I'm making the same changes to the other PRs... I assume this addresses your concern to the point where you'll approve merging the section?
…llTed. Co-authored-by: Amy Guy <[email protected]> Co-authored-by: Ted Thibodeau Jr <[email protected]>
There was a problem hiding this comment.
Agree with merging after applying suggestions https://github.com/w3c/did-core/pull/653/files#r577646064 and https://github.com/w3c/did-core/pull/653/files#r577778177.
Co-authored-by: Markus Sabadello <[email protected]>
|
Substantive, multiple reviews, changes requested and made, objection raised by @peacekeeper and addressed via specification text change, no sustained objections, merging. |
This PR attempts to clean up the JSON Production and Consumption section in a way that enables the data model to be serialized for data structures other than a DID Document (to align it with the Resolution serialization requirements), while keeping the DID Document serialization rules more or less the same. There was wierdness related to tying the resolution section in normatively to the production/consumption rules, which really should be done higher up in the stack. I'm marking it as substantive because, while I'm fairly certain implementations wouldn't be affected by the changes, normative language was changed/merged/removed.
Preview | Diff