-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add brief historical perspective in acknowledgements. #790
Conversation
92069fa
to
cc7217a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
Before merging the echidna action should be switched off (I guess the yml file should be removed) to avoid the merge leading to a new TR publication. |
I have disabled Echidna auto-publish here: https://github.com/w3c/did-core/actions/workflows/auto-publish.yml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Manu, good job summarizing a lot of history in a short space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One tweak, to broaden the influential "tech and specs" which I think includes more than PGP, though that may be all that gets called out here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, here are 2 small suggestions.
The issue was discussed in a meeting on 2021-08-17 List of resolutions:
View the transcript3. historical PRSee github pull request #790. Brent Zundel: Anything else on this topic? Manu Sporny: It's currently written as the editors writing this, I'd like to upgrade it to the WG writing it.
Manu Sporny: I don't think there is anything controversial, we'd like to acknowledge the work before there was a DID WG.
Manu Sporny: We'd like to give people an understanding that this work started long ago.
Manu Sporny: Would anyone object to change this from "the editors acknowledge" to "the WG acknowledges", or similar
Ivan Herman: It's more appropriate if it says "the WG" rather than "the editors"
Ivan Herman: This is only editorial, so I don't think anyone would object from a process point of view. Manu Sporny: Should we document a WG resolution, to make absolutely sure? Brent Zundel: Any changes to the proposal?
Ivan Herman: Do we say somewhere in the document that all appendices are non-normative? Manu Sporny: It doesn't say that, I can add it. We have it for all other sections.
Manu Sporny: I'm going to raise an issue. Brent Zundel: Anything else on this topic? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm requesting these changes.
Co-authored-by: rxgrant <[email protected]>
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Co-authored-by: Markus Sabadello <[email protected]>
Co-authored-by: Markus Sabadello <[email protected]>
154d8a0
to
4fa0d15
Compare
The issue was discussed in a meeting on 2021-08-24
View the transcript5. DID core issuesSee github pull request #792, #790. Manu Sporny: Just wanted to draw attention to the two issues on DID Core. Daniel Burnett: Alrighty. Manu Sporny: There are two PRs for DID Core: one of them is the acknowledgement section - I believe that is completely ready to merge... Well, there's one minor thing and then it's ready to merge.
Manu Sporny: "mostly editorial" -> I am asserting both of these things are entirely editorial - and would be surprised if anyone said otherwise. Drummond Reed: I've looked at them and agree it's editorial. Not an issue.
Daniel Burnett: I'm not hearing any objections to pulling them in - when the time is right. Manu Sporny: Editors... are we good to go?
Brent Zundel: To my understanding, he is satisfied.
|
Co-authored-by: Ted Thibodeau Jr <[email protected]>
Editorial, multiple reviews, changes requested and made, no sustained objections, WG resolution to merge, merging. |
Herman, for their tireless work in keeping the Working Group headed in a | ||
productive direction and navigating the deep and dangerous waters of the | ||
standards process. | ||
The Working Group extends deep appreciation and heartfelt thanks to our Chairs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noticed it after you merged it...
The Working Group extends deep appreciation and heartfelt thanks to our Chairs | |
The Working Group extends deep appreciation and heartfelt thanks to our Chairs, |
This adds a brief historical perspective on the specification before it entered the DID WG and acknowledges/appreciates the individuals that worked on the proto-documents that led to the DID Specification.
See the new text here: https://pr-preview.s3.amazonaws.com/w3c/did-core/pull/790.html#acknowledgements
Preview | Diff