Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate CBOR representation to NOTE #735

Merged
merged 3 commits into from
May 22, 2021
Merged

Migrate CBOR representation to NOTE #735

merged 3 commits into from
May 22, 2021

Conversation

msporny
Copy link
Member

@msporny msporny commented May 15, 2021

This PR implements the first part of the following DID WG resolution:

Resolution #1 on 2021-05-04: remove CBOR from the DID Core Specification, publish it as a WG Note, and add CBOR to the DID Spec Registries with a reference to the WG Note

All of the content of the CBOR section has saved and migrated to https://msporny.github.io/did-representation-cbor/index.html , which is pending transfer to W3C via @iherman.


Preview | Diff

@iherman
Copy link
Member

iherman commented May 16, 2021

@msporny

All of the content of the CBOR section has saved and migrated to https://msporny.github.io/did-representation-cbor/index.html , which is pending transfer to W3C via @iherman.

@msporny, I have created https://github.com/w3c/did-cbor-note right after the working group call (and I believe I notified you about it...), ie, it was unnecessary to do it in a different repo...

Anyway, I have copied index.html and common.js to the official repo, and changed the github repository reference in index.html. For some reason, though, github had problem creating the github page; I am not sure why. It may be a temporary github problem (I can look at it later, but you may be able to bit me into it.)

@msporny
Copy link
Member Author

msporny commented May 16, 2021

@msporny, I have created https://github.com/w3c/did-cbor-note right after the working group call (and I believe I notified you about it...), ie, it was unnecessary to do it in a different repo...

Ah, I didn't know.

I've tried to splice the correct history together for the new repo, but don't have the rights to force push to the main branch to clean up the history... can you please give me access to force push to the main branch?

If not, please make https://github.com/w3c/did-cbor-note/tree/main-spliced-history the main branch.

@msporny msporny added cr-comment substantive This is a substantive change to the specification. labels May 16, 2021
@iherman
Copy link
Member

iherman commented May 16, 2021

@msporny, I hope I found the right settings in the cbor repository...

@msporny
Copy link
Member Author

msporny commented May 16, 2021

@msporny, I hope I found the right settings in the cbor repository...

Hooray, you did. I was able to force-push main... history is correct now, feel free to put branch protection back on main now.

The spec is now available here:

https://w3c.github.io/did-cbor-note/

@iherman
Copy link
Member

iherman commented May 17, 2021

Hooray, you did. I was able to force-push main... history is correct now, feel free to put branch protection back on main now.

That is part of the branch protection part; I will just leave it as is.

@msporny
Copy link
Member Author

msporny commented May 22, 2021

Substantive (but covered by an at risk marker noting potential removal), multiple positive reviews, no objections, merging.

@msporny msporny merged commit 20b0299 into main May 22, 2021
@msporny msporny deleted the msporny-cr-migrate-cbor branch May 30, 2021 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
substantive This is a substantive change to the specification.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants