-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "key-type" DID URL matrix parameter. #60
Conversation
This adds one concrete DID URL matrix parameter. Description: Identifies a set of keys from the DID Document by key type. Example: |
-1 to merging as is because I don't know what the purpose of this parameter is and because it seems like it would tend to produce a set of keys whilst losing their authorized purpose (which could be dangerous). It is also "key" specific, not allowing for other types (i.e., why not "type="?). |
I don't understand the use case here... why can't you just write a function to go through the DID Document and fetch all of these keys? I'm trying to understand where we'd put a value like this -- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we should not merge this until we've determined whether there is actually consensus to resurrect the matrix parameter syntax at all. Less is more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe that we should not merge this until we've determined whether there is actually consensus to resurrect the matrix parameter syntax at all. Less is more.
I believe the consensus on this was that its not a good idea, and we should close this PR. |
Agreed... @peacekeeper can we close this PR? |
@peacekeeper can we close this? |
@msporny @brentzundel @burnburn can we get labels on all the open PRs related to changes that have matrix parameters in them, and mark them as "pending-close"... we have a lot of PRs open... PRs should not remain open unless they are being worked on / going to be merged within a week or 2.... we are loosing the ability to focus reviews on things that need reviews... |
Marked pending close after the resolution 1 on the 4/7/2020 call. |
I agree this should be closed, but the reason for closing is that there has been consensus that there is no need for having |
Let's take this up on the next special topic call since we're still discussing the general area of DID Parameters. |
Sounds good, I'll hold off on taking any other action until I see confirmation from an editor or chair and will instead prompt others to take action if I see it becomes stale. |
Re-creating PR from CCG repo: w3c-ccg/did-spec#193. Please consider earlier discussions there.
Preview | Diff