Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "key-type" DID URL matrix parameter. #60

Closed
wants to merge 2 commits into from

Conversation

peacekeeper
Copy link
Contributor

@peacekeeper peacekeeper commented Oct 5, 2019

Re-creating PR from CCG repo: w3c-ccg/did-spec#193. Please consider earlier discussions there.


Preview | Diff

@peacekeeper
Copy link
Contributor Author

This adds one concrete DID URL matrix parameter.

Description: Identifies a set of keys from the DID Document by key type.

Example: did:example:1234;key-type=Ed25519VerificationKey2018

@dlongley
Copy link
Contributor

dlongley commented Oct 5, 2019

-1 to merging as is because I don't know what the purpose of this parameter is and because it seems like it would tend to produce a set of keys whilst losing their authorized purpose (which could be dangerous). It is also "key" specific, not allowing for other types (i.e., why not "type="?).

@msporny
Copy link
Member

msporny commented Oct 10, 2019

did:example:1234;key-type=Ed25519VerificationKey2018

I don't understand the use case here... why can't you just write a function to go through the DID Document and fetch all of these keys?

I'm trying to understand where we'd put a value like this -- did:example:1234;key-type=Ed25519VerificationKey2018 ... like, we'd put it in a database table because we'd want to get the set of all Ed25519VerificationKey2018s, but I'm struggling to figure out why we'd put this value in a database table vs. just write a function to extract what we want from the DID Document?

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we should not merge this until we've determined whether there is actually consensus to resurrect the matrix parameter syntax at all. Less is more.

Copy link
Contributor

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that we should not merge this until we've determined whether there is actually consensus to resurrect the matrix parameter syntax at all. Less is more.

@OR13
Copy link
Contributor

OR13 commented Feb 7, 2020

I believe the consensus on this was that its not a good idea, and we should close this PR.

@msporny
Copy link
Member

msporny commented Feb 7, 2020

I believe the consensus on this was that its not a good idea, and we should close this PR.

Agreed... @peacekeeper can we close this PR?

@OR13
Copy link
Contributor

OR13 commented Mar 15, 2020

@peacekeeper can we close this?

@OR13
Copy link
Contributor

OR13 commented Apr 7, 2020

@msporny @brentzundel @burnburn can we get labels on all the open PRs related to changes that have matrix parameters in them, and mark them as "pending-close"... we have a lot of PRs open... PRs should not remain open unless they are being worked on / going to be merged within a week or 2.... we are loosing the ability to focus reviews on things that need reviews...

@kdenhartog kdenhartog added the pending close Issue will be closed shortly if no objections label Apr 7, 2020
@kdenhartog
Copy link
Member

kdenhartog commented Apr 7, 2020

Marked pending close after the resolution 1 on the 4/7/2020 call.

@peacekeeper
Copy link
Contributor Author

Marked pending close after the resolution 1 on the 4/7/2020 call.

I agree this should be closed, but the reason for closing is that there has been consensus that there is no need for having key-type as a DID parameter in the DID URL. The resolution on the 2020-04-07 call was about the syntax of DID parameters, which is independent of the question which DID parameters we want.

@msporny
Copy link
Member

msporny commented Apr 10, 2020

Let's take this up on the next special topic call since we're still discussing the general area of DID Parameters.

@kdenhartog
Copy link
Member

Let's take this up on the next special topic call since we're still discussing the general area of DID Parameters.

Sounds good, I'll hold off on taking any other action until I see confirmation from an editor or chair and will instead prompt others to take action if I see it becomes stale.

@msporny msporny closed this Apr 20, 2020
@msporny msporny deleted the peacekeeper-matrix-parameter-key-type branch May 1, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pending close Issue will be closed shortly if no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants