Remove '?' from dictionary members of DeviceMotionEventInit #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is invalid for a dictionary member that resolves to a nullable type to be marked with '?'. This change is effectively a no-op because these fields remain nullable. Resolves w3c#54.
|
Pending #54 to reach consensus, would also like to see @bzbarsky sign off this spec change to make sure we coordinate with Gecko. Related, not specified is the expected behavior when a |
|
The IDL change looks fine as far as it goes. I'll follow up in #54 with some comments about what is or is not specified. |
|
Discussed at Devices and Sensors WG Face-to-face at TPAC 2018. Agreed to accept this change. |
aarongable
pushed a commit
to chromium/chromium
that referenced
this pull request
Nov 21, 2018
It is invalid for a WebIDL dictionary member that resolves to a nullable type to be marked with '?'. This change is effectively a no-op because these fields remain nullable. This patch implements the changes to the specification in: w3c/deviceorientation#55 Change-Id: I43222ec37ec216f8cb2932aedbddfb307ec4374f Reviewed-on: https://chromium-review.googlesource.com/c/1239722 Commit-Queue: Reilly Grant <[email protected]> Reviewed-by: Kentaro Hara <[email protected]> Cr-Commit-Position: refs/heads/master@{#609930}
reillyeon
added a commit
that referenced
this pull request
Feb 28, 2024
This change reverts #55 and defines the default values of the DeviceMotionEventInit as null as I believe was the original intent of the definition before that change. Null DeviceMotionEvent attributes have semantic meaning (they declare that the host does not provide the given sensor) and so script should be able to initialize an event with its attributes set to null. Fixed #91.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is invalid for a dictionary member that resolves to a nullable type
to be marked with '?'. This change is effectively a no-op because these
fields remain nullable.
Resolves #54.