Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editorial: automatically generate the conformance section #155

Merged
merged 2 commits into from
May 7, 2024

Conversation

marcoscaceres
Copy link
Member

@marcoscaceres marcoscaceres commented May 2, 2024

Drop redundant text and just let bikeshed generate the conformance section.


Preview | Diff

@marcoscaceres marcoscaceres requested a review from reillyeon May 2, 2024 01:26
Copy link
Member

@rakuco rakuco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to remove omit conformance from the Bikeshed header, otherwise we'll end up with no conformance section at all.

@rakuco
Copy link
Member

rakuco commented May 2, 2024

You need to remove omit conformance from the Bikeshed header, otherwise we'll end up with no conformance section at all.

I've just noticed that this is being done in #154.

@marcoscaceres
Copy link
Member Author

Thanks @rakuco. I'll fix "omit conformance" as part of this one.

@marcoscaceres marcoscaceres requested a review from rakuco May 3, 2024 05:09
Drop redundant text and just let bikeshed generate the conformance section.
@marcoscaceres marcoscaceres merged commit 21d1db5 into main May 7, 2024
2 checks passed
@marcoscaceres marcoscaceres deleted the remove_conformance branch May 7, 2024 04:10
github-actions bot added a commit that referenced this pull request May 7, 2024
SHA: 21d1db5
Reason: push, by marcoscaceres

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants