Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Joint deliverables #126

Merged
merged 6 commits into from
Jun 21, 2023
Merged

Joint deliverables #126

merged 6 commits into from
Jun 21, 2023

Conversation

anssiko
Copy link
Member

@anssiko anssiko commented Dec 2, 2022

Related #123


Preview | Diff

@netlify
Copy link

netlify bot commented Dec 2, 2022

Deploy Preview for w3c-das-charter ready!

HTML diff

Edit: add HTML diff built with the good old htmldiff, remove broken links to the Netlify Deploy Preview.

@anssiko
Copy link
Member Author

anssiko commented Dec 2, 2022

This PR is based on the current DAS WG charter and is synchronized with the current Web Apps WG charter and thus adds Contact Picker API as a joint deliverable.

Other joint deliverables may be added subject to bilateral discussions.

See also: HTML diff between the current DAS WG charter and this PR.

Also make the joint deliverable status Notes more prominent.
Copy link

@tomayac tomayac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Non-owner LGTM

Comment on lines 580 to 582
<p class="issue">
<b>Note:</b> This work is a possible joint deliverable with the <a href="https://www.w3.org/groups/wg/webapps">Web Applications Working Group</a>.
</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already a fact:

Suggested change
<p class="issue">
<b>Note:</b> This work is a possible joint deliverable with the <a href="https://www.w3.org/groups/wg/webapps">Web Applications Working Group</a>.
</p>
<p>
This work is a joint deliverable with the <a href="https://www.w3.org/groups/wg/webapps">Web Applications Working Group</a>.
</p>

See below from what's on TR:

Screenshot 2023-04-20 at 11 24 49 am

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 3dc341b

Remove "possible", entered TR on 2022-12-20
@@ -259,7 +259,10 @@ <h3 id="rec-track">
Produced under <b>Working Group Charter:</b> <a href=
"https://www.w3.org/2016/03/device-sensors-wg-charter.html">https://www.w3.org/2016/03/device-sensors-wg-charter.html</a>
</p>
</dd>
<p class="issue">
<b>Note:</b> This work is a possible joint deliverable with the <a href="https://www.w3.org/groups/wg/webapps">Web Applications Working Group</a>.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<b>Note:</b> This work is a possible joint deliverable with the <a href="https://www.w3.org/groups/wg/webapps">Web Applications Working Group</a>.
<b>Note:</b> This work is a joint deliverable with the <a href="https://www.w3.org/groups/wg/webapps">Web Applications Working Group</a>.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed by 14e2ce9

@marcoscaceres
Copy link
Member

marcoscaceres commented Apr 25, 2023

could we make it so that this PR only includes the joint deliverable? It will make it easier to review on our side 🙏

@reillyeon
Copy link
Member

could we make it so that this PR only includes the joint deliverable? It will make it easier to review on our side 🙏

+1, moving around Compute Pressure makes the diff harder to read given the HTML preview seems to be broken.

Remove "possible", entered TR on 2015-02-12
@anssiko anssiko force-pushed the joint-deliverables branch from b39d4a9 to 14e2ce9 Compare April 26, 2023 07:09
@anssiko
Copy link
Member Author

anssiko commented Apr 26, 2023

Moved Compute Pressure changes to PR #128, updated this PR accordingly and addressed comments.

@himorin can you please fix the HTML preview and diff.

@anssiko anssiko mentioned this pull request Apr 26, 2023
Copy link
Member

@reillyeon reillyeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates. This looks good to me.

@himorin
Copy link
Contributor

himorin commented Apr 28, 2023

@himorin can you please fix the HTML preview and diff.

@anssiko .pr-preview.json itself does not exist... I'll file a PR to setup pr-preview, but was it really worked for this repository!!??

Copy link
Member

@marcoscaceres marcoscaceres left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should list:

  • Geolocation
  • Screen Wake Lock
  • DeviceOrientation Event

As joint deliverables.

@marcoscaceres
Copy link
Member

I think we are still waiting on the charter update to list the above joint deliverables with WebApps WG.

@marcoscaceres
Copy link
Member

Just FYI, here is the proposed Web Apps Charter listing the join deliverables:
https://w3c.github.io/webappswg/charter/draft-charter-2023.html

It's expected that the updated charter will go for review to the AC in June, so would be great to have this one up to date also.

Matches the joint deliverables from the proposed Web Applications Working Group charter: https://w3c.github.io/webappswg/charter/draft-charter-2023.html
@reillyeon
Copy link
Member

@anssiko, given I just modified this change I will wait for your approval as co-chair before merging.

@anssiko
Copy link
Member Author

anssiko commented Jun 19, 2023

@reillyeon, bd57663 and https://w3c.github.io/webappswg/charter/draft-charter-2023.html refer to a different Geolocation spec.

I believe WebApps WG's aspiration is to help with the maintenance of the Geolocation API that has reached the W3C Recommendation status (and is revised per https://www.w3.org/2023/Process-20230612/#revising-rec). Recommendations are listed under the Maintenance section of the charter.

@reillyeon
Copy link
Member

@reillyeon, bd57663 and https://w3c.github.io/webappswg/charter/draft-charter-2023.html refer to a different Geolocation spec.

Oops, fixed.

@anssiko anssiko merged commit b9a424b into gh-pages Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants