Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[css-values-4][css-images-4][css-fonts-4] URL request modifiers #8222

Merged
merged 10 commits into from
Mar 7, 2023

Conversation

noamr
Copy link
Collaborator

@noamr noamr commented Dec 14, 2022

Added a few URL modifiers to enable request parameters:

3 modifiers that correspond to link attributes:

This enables CORS requests for CSS images, credentialed requests for fonts, and fine-tuning using integrity etc.

Example:
url("https://..." crossorigin(anonymous) integrity("shaX--something") referrerpolicy(same-origin))

See #1603

css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
noamr and others added 6 commits December 15, 2022 06:55
@noamr
Copy link
Collaborator Author

noamr commented Dec 15, 2022

Thanks for the initial pass, @tabatkins... I was hoping bikeshed would run on the PR first but for some reason IPR check failed.

@noamr noamr changed the title WIP: [css-values-4][css-images-4][css-values-4] URL request modifiers [css-values-4][css-images-4][css-values-4] URL request modifiers Dec 15, 2022
@noamr noamr changed the title [css-values-4][css-images-4][css-values-4] URL request modifiers [css-values-4][css-images-4][css-fonts-4] URL request modifiers Dec 15, 2022
@noamr
Copy link
Collaborator Author

noamr commented Jan 25, 2023

Thanks for the initial pass, @tabatkins... I was hoping bikeshed would run on the PR first but for some reason IPR check failed.

@tabatkins ping ?

@noamr
Copy link
Collaborator Author

noamr commented Mar 7, 2023

Thanks for the initial pass, @tabatkins... I was hoping bikeshed would run on the PR first but for some reason IPR check failed.

@tabatkins ping ?

Another ping @tabatkins ?

Copy link
Member

@tabatkins tabatkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits for linebreak formatting; each has a suggestion you can just accept. R+ after that!

css-values-4/Overview.bs Outdated Show resolved Hide resolved
css-values-4/Overview.bs Outdated Show resolved Hide resolved
@tabatkins
Copy link
Member

nm, i can accept my own suggestions.

@tabatkins tabatkins merged commit 8fb2816 into w3c:main Mar 7, 2023
@noamr noamr deleted the req-modifiers branch March 8, 2023 04:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants