[css-transforms] scale function and property % #4396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewilligers
force-pushed
the
scale-percentage
branch
from
18bc49b to
d849d7a
Compare
|
This change should be made in css-transforms-2, not css-transforms-1. |
ewilligers
force-pushed
the
scale-percentage
branch
from
d849d7a to
707a156
Compare
|
I have updated to PR to only involve css-transforms-2. I have also described serialization. |
|
@tabatkins @smfr @grorg @hober please review |
smfr
requested changes
Nov 20, 2019
css-transforms-2/Overview.bs
Outdated
| @@ -627,6 +627,10 @@ If three values are given, | |||
| this specifies a 3d scaling, | |||
| equivalent to the ''scale3d()'' function. | |||
|
|
|||
| A <<percentage>> is equivalent to a <<number>>, | |||
| for example ''scale: 100%;'' is equivalent to ''scale: 1;''. | |||
| Numbers are used during serialization. | |||
There was a problem hiding this comment.
I think this should move to section 4.1, about serialization.
css-transforms-2/Overview.bs
Outdated
| @@ -878,6 +882,19 @@ The Transform Functions {#transform-functions} | |||
| ======================= | |||
|
|
|||
| The value of the 'transform' property is a list of <dfn><transform-function></dfn>. The set of allowed transform functions is given below. Wherever <<angle>> is used in this specification, a <<number>> that is equal to zero is also allowed, which is treated the same as an angle of zero degrees. A percentage for horizontal translations is relative to the width of the <a>reference box</a>. A percentage for vertical translations is relative to the height of the <a>reference box</a>. | |||
| A percentage in a scale function is equivalent to a number, and serializes as a number. | |||
There was a problem hiding this comment.
I think this should move to section 4.1, about serialization.
|
Ah it's section 2.1 in transforms-2 |
|
Section 2.1 is about computed value serialization. Percentages in scale serialize as numbers even in the specified value. Are you requesting a new section about specified value serialization? |
|
It wasn't clear from "serializes as a number" whether you were talking about specified or computed. Maybe clarify? |
Allow percentages inside the scale functions, and the scale property. resolves w3c#3399
ewilligers
force-pushed
the
scale-percentage
branch
from
707a156 to
3b5fa27
Compare
Updated. |
Ernedar
approved these changes
Jul 23, 2020
|
Waiting for approval from an editor.
|
smfr
approved these changes
Sep 26, 2020
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 27, 2021
The functions scale() scaleX() scaleY() scaleZ() scale3d() and the property scale each accept percentages, that serialize as numbers. w3c/csswg-drafts#3399 w3c/csswg-drafts#4396 https://drafts.csswg.org/css-transforms-2/#transform-functions https://drafts.csswg.org/css-transforms-2/#propdef-scale Bug: 1179579 Change-Id: Icfbc42bf529c1c63045c3e918a6a1db2b14d1ae3
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 27, 2021
The functions scale() scaleX() scaleY() scaleZ() scale3d() and the property scale each accept percentages, that serialize as numbers. w3c/csswg-drafts#3399 w3c/csswg-drafts#4396 https://drafts.csswg.org/css-transforms-2/#transform-functions https://drafts.csswg.org/css-transforms-2/#propdef-scale Bug: 1179579 Change-Id: Icfbc42bf529c1c63045c3e918a6a1db2b14d1ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2703674 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/master@{#867008}
chromium-wpt-export-bot
pushed a commit
to web-platform-tests/wpt
that referenced
this pull request
Mar 27, 2021
The functions scale() scaleX() scaleY() scaleZ() scale3d() and the property scale each accept percentages, that serialize as numbers. w3c/csswg-drafts#3399 w3c/csswg-drafts#4396 https://drafts.csswg.org/css-transforms-2/#transform-functions https://drafts.csswg.org/css-transforms-2/#propdef-scale Bug: 1179579 Change-Id: Icfbc42bf529c1c63045c3e918a6a1db2b14d1ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2703674 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/master@{#867008}
pull bot
pushed a commit
to luojiguicai/chromium
that referenced
this pull request
Mar 27, 2021
The functions scale() scaleX() scaleY() scaleZ() scale3d() and the property scale each accept percentages, that serialize as numbers. w3c/csswg-drafts#3399 w3c/csswg-drafts#4396 https://drafts.csswg.org/css-transforms-2/#transform-functions https://drafts.csswg.org/css-transforms-2/#propdef-scale Bug: 1179579 Change-Id: Icfbc42bf529c1c63045c3e918a6a1db2b14d1ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2703674 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/master@{#867008}
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
Mar 27, 2021
…ges., a=testonly Automatic update from web-platform-tests CSS Transforms: scale() accepts percentages. The functions scale() scaleX() scaleY() scaleZ() scale3d() and the property scale each accept percentages, that serialize as numbers. w3c/csswg-drafts#3399 w3c/csswg-drafts#4396 https://drafts.csswg.org/css-transforms-2/#transform-functions https://drafts.csswg.org/css-transforms-2/#propdef-scale Bug: 1179579 Change-Id: Icfbc42bf529c1c63045c3e918a6a1db2b14d1ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2703674 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/master@{#867008} -- wpt-commits: 808a9ed80e45a9da615fb930d212fcc7461648e6 wpt-pr: 28267
Chi-teck
added a commit
to Chi-teck/content-1
that referenced
this pull request
Jan 16, 2022
Chi-teck
added a commit
to Chi-teck/content-1
that referenced
this pull request
Jan 16, 2022
Chi-teck
added a commit
to Chi-teck/content-1
that referenced
this pull request
Jan 16, 2022
mjfroman
pushed a commit
to mjfroman/moz-libwebrtc-third-party
that referenced
this pull request
Oct 14, 2022
The functions scale() scaleX() scaleY() scaleZ() scale3d() and the property scale each accept percentages, that serialize as numbers. w3c/csswg-drafts#3399 w3c/csswg-drafts#4396 https://drafts.csswg.org/css-transforms-2/#transform-functions https://drafts.csswg.org/css-transforms-2/#propdef-scale Bug: 1179579 Change-Id: Icfbc42bf529c1c63045c3e918a6a1db2b14d1ae3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2703674 Commit-Queue: Eric Willigers <[email protected]> Reviewed-by: Anders Hartvoll Ruud <[email protected]> Cr-Commit-Position: refs/heads/master@{#867008} GitOrigin-RevId: f31adb81393ef56e06da6d2a3e5ec42ef19a25b1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow percentages inside the scale functions,
and the scale property.
resolves #3399