-
Notifications
You must be signed in to change notification settings - Fork 676
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[mediaqueries-5] Migrate Web Preferences API proposal #10597
Conversation
<h2 id=auto-pref> | ||
Script Control of User Preferences</h3> | ||
|
||
It is common for website authors to want to respect the user's system preferences while also allowing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably needs a bit of a better introduction here. Perhaps with more from https://wicg.github.io/web-preferences-api/#sec-intro
TODO: It seems like the proposal and the spec use different flavours of bikeshed syntax, so I probably need to migrate to match the spec @tabatkins I don't suppose there's a tool to convert from the shorthand to the more HTML like syntax is there? TODO: Add to the privacy section, at the very least an inline issue to signpost that it needs filling in. |
Don't worry about it.
Doesn't need much since there isn't actually a privacy concern, but it would be good to highlight why there isn't, yes, along the lines of what we've discussed in the issues. Maybe something like:
|
2832832
to
9a52b50
Compare
@tabatkins apologies for the massive delay in getting back to this. I've added in your suggestions to the privacy section. I'd appreciate an overall review when you get time. I'll work on migrating the issues across to this repo, probably once this PR is merged. |
@tabatkins is this ready to merge? Just an fyi I don't have merge rights so I can't do it myself :) |
Thanks! |
Per resolution at #6517 (comment) this migrates the Web Preferences API to the Media Queries Level 5 spec.