Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[mediaqueries-5] Migrate Web Preferences API proposal #10597

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

lukewarlow
Copy link
Member

Per resolution at #6517 (comment) this migrates the Web Preferences API to the Media Queries Level 5 spec.

<h2 id=auto-pref>
Script Control of User Preferences</h3>

It is common for website authors to want to respect the user's system preferences while also allowing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs a bit of a better introduction here. Perhaps with more from https://wicg.github.io/web-preferences-api/#sec-intro

@lukewarlow
Copy link
Member Author

TODO: It seems like the proposal and the spec use different flavours of bikeshed syntax, so I probably need to migrate to match the spec @tabatkins I don't suppose there's a tool to convert from the shorthand to the more HTML like syntax is there?

TODO: Add to the privacy section, at the very least an inline issue to signpost that it needs filling in.

@tabatkins
Copy link
Member

so I probably need to migrate to match the spec

Don't worry about it.

Add to the privacy section, at the very least an inline issue to signpost that it needs filling in.

Doesn't need much since there isn't actually a privacy concern, but it would be good to highlight why there isn't, yes, along the lines of what we've discussed in the issues. Maybe something like:

The {{PreferenceManager}} object allows querying some user-preference [=media features=]. This is not a privacy leak, as that information was always trivially available by using the [=media features=] themselves in the normal fashion.

The {{PreferenceManager}} object also allows overriding these user-preference [=media features=]; this is also neither a privacy nor accessibility regression, as the [=media features=] were already trivially ignorable by simply not querying them.

@lukewarlow lukewarlow force-pushed the web-preferences-api branch from 2832832 to 9a52b50 Compare August 29, 2024 17:07
@lukewarlow
Copy link
Member Author

@tabatkins apologies for the massive delay in getting back to this. I've added in your suggestions to the privacy section. I'd appreciate an overall review when you get time. I'll work on migrating the issues across to this repo, probably once this PR is merged.

@lukewarlow lukewarlow marked this pull request as ready for review August 30, 2024 22:56
@lukewarlow
Copy link
Member Author

@tabatkins is this ready to merge? Just an fyi I don't have merge rights so I can't do it myself :)

@svgeesus svgeesus merged commit 64db295 into w3c:main Sep 17, 2024
1 check passed
@lukewarlow lukewarlow deleted the web-preferences-api branch September 17, 2024 14:14
@lukewarlow
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants