Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[css-scrollbars] Scrollbar properties on the root element should be propagated to viewport #2696

Closed
upsuper opened this issue May 23, 2018 · 4 comments
Closed

[css-scrollbars] Scrollbar properties on the root element should be propagated to viewport #2696

upsuper opened this issue May 23, 2018 · 4 comments
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-scrollbars-1 Current Work

Comments

@upsuper
Copy link
Member

upsuper commented May 23, 2018

Scrollbar properties on the root element should be propagated to viewport, similar to what we do for overflow properties. Otherwise, there would be no way to style scrollbars of viewport.
@upsuper upsuper added the css-scrollbars-1 Current Work label May 23, 2018
@upsuper upsuper mentioned this issue May 23, 2018
Closed
@tantek
Copy link
Member

tantek commented May 23, 2018

Thanks <https://github.com/upsuper> and good call. Do you have any preferred wording for this, or shall I clone language from <https://drafts.csswg.org/css-overflow/#overflow-propagation> ?

(Originally published at: http://tantek.com/2018/143/t2/)

@upsuper
Copy link
Member Author

upsuper commented May 23, 2018 •
edited
Loading

I think we only need

UAs must apply the scrollbar-* values set on the root element to the viewport.

Sentences for overflow after that are basically for webcompat reason, which we shouldn't take. That's not something we want to spread.

Maybe we should add a note to mention that this is different from overflow that values on <body> wouldn't be propagated to viewport.

tantek added a commit that referenced this issue May 24, 2018
@tantek
root scrollbar colors also set on viewport #2696
050fb09 
Per issue #2696, root scrollbar colors also set viewport scrollbar colors. Also add explicit intro paragraph about where spec source is because "Repository:" metadata block appears to do nothing (does not work to add a link to the GitHub repo).
@tantek
Copy link
Member

tantek commented May 24, 2018

<https://github.com/upsuper> your suggested text makes sense to me, and I have also added an explicit note so implementers hopefully don’t accidentally propagate body to viewport.

Please take a look at the prose after the property value table at <https://drafts.csswg.org/css-scrollbars-1/#scrollbar-color-properties> and if the updates are sufficient to resolve this issue, go ahead and close.

(Originally published at: http://tantek.com/2018/143/t5/)

@upsuper
Copy link
Member Author

upsuper commented May 24, 2018

The spec currently only has scrollbar color properties so far, but I think this should probably apply to any future scrollbar properties as well (e.g. something controlling the width of scrollbar)? We may want to put it in an independent section or so, I guess...

But the current wording is enough for resolving this issue so I'm going to close it for now.

@upsuper upsuper closed this as completed May 24, 2018
@frivoal frivoal added Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Closed Accepted by Editor Discretion Commenter Satisfied Commenter has indicated satisfaction with the resolution / edits. css-scrollbars-1 Current Work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tantek @frivoal @upsuper