Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move at-risk to experimental #300

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Move at-risk to experimental #300

merged 1 commit into from
Nov 22, 2024

Conversation

kenchris
Copy link
Contributor

@kenchris kenchris commented Nov 21, 2024

"at risk" in spec means it can be removed at CR stage and then go to REC directly.

Features not marked as "at risk" and removed at CR require to do another CR before REC

In this case removing seems appropriate as we will have no "at risk" features in the spec.


Preview | Diff

@kenchris kenchris requested a review from arskama November 21, 2024 09:59
@anssiko
Copy link
Member

anssiko commented Nov 21, 2024

I believe it is recommended to not rely on script-based manipulation of text content, but remove the text. IIRC W3C's publication rules checker does not like custom scripts that manipulate text content. @himorin to confirm.

@kenchris
Copy link
Contributor Author

This is now using a respec plugin, so I guess this will work :-)

@kenchris
Copy link
Contributor Author

Seems to work @anssiko https://github.com/w3c/compute-pressure/actions/runs/11952638521/job/33318791234?pr=300 This is using a respec preprocess hook

@kenchris
Copy link
Contributor Author

This seems to work fine and an improvement on what we have today (existing custom code) so going to merge

@kenchris kenchris merged commit 3288c5b into w3c:main Nov 22, 2024
2 checks passed
@anssiko
Copy link
Member

anssiko commented Nov 22, 2024

Using the ReSpec preprocessing hook (as in this PR) to remove content before HTML generation allows the generated https://www.w3.org/TR/compute-pressure/ to pass W3C's publication rules checker.

And only the ED accepts an URL parameter to turn the experimental features on: https://w3c.github.io/compute-pressure/?experimental=1, e.g. in this PR "thermals" PressureSource.

@himorin to flag any issues in this approach, but I think this should be fine.

@anssiko anssiko mentioned this pull request Nov 22, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants