Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide guidelines for mitigation algorithms #241

Merged
merged 5 commits into from
Nov 3, 2023
Merged

Provide guidelines for mitigation algorithms #241

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8b67027
Provide guidelines for mitigation algorithms
arskama Oct 30, 2023
8397ac5
Fix first comments from rakuco
arskama Nov 1, 2023
17268d8
Change some parameters to normative parameters.
arskama Nov 2, 2023
d0be26d
Add Notes about possible values change.
arskama Nov 3, 2023
7ca2301
Fix typo
arskama Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 33 additions & 3 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -883,7 +883,7 @@ <h3>Supporting algorithms</h3>
<ul>
<li>
set |observer|.{{PressureObserver/[[ObservationWindow]]}} to an [=implementation-defined=] randomized integer value in
milliseconds within an [=implementation-defined=] range, e.g., random between 300000 and 600000 (5 and 10 minutes).
milliseconds within an [=implementation-defined=] range.
</li>
<li>
set |observer|.{{PressureObserver/[[MaxChangesThreshold]]}} to an [=implementation-defined=] randomized integer
Expand Down Expand Up @@ -1429,6 +1429,25 @@ <h4>Rate obfuscation</h4>
received from the platform collector during this penalty.
</p>
</section>
<section>
<h4>Rate obfuscation parameters</h4>
<p><i>This section is non-normative.</i></p>
<p>
Based on implementation experience, implementers are advised to use:
<ul>
<li>
a range in between 300000 milliseconds (5 minutes) and 600000 milliseconds (10 minutes) for |observer|.{{PressureObserver/[[ObservationWindow]]}}.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Editorial nitpick: the |variable| notation is generally used in algorithms. observer has not been defined here. I'd just say something along the lines of "a range [...] for PressureObserver's [[ObservationWindow]] internal slot".

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree!

</li>
<li>
a range in between 50 and 100 changes for |observer|.{{PressureObserver/[[MaxChangesThreshold]]}}.
</li>
<li>
a range in between 5000 milliseconds and 10000 milliseconds for |observer|.{{PressureObserver/[[PenaltyDuration]]}}.
</li>
</ul>
These values are subject to change and are updated based on further implementation experience and research findings.
</p>
</section>
<section>
<h4>Break calibration</h4>
<p>
Expand All @@ -1442,14 +1461,25 @@ <h4>Break calibration</h4>
at runtime when this mitigation is running continuously. Any attempts to recalibrate
will similarly be mitigated against.
</p>
<div class="note">
<aside class="note">
Modern browsers throttle background tabs using [=implementation-defined=]
heuristics in order to reduce resource usage. For example, after a period of
no user interaction a background tab can be throttled that will influence
the global pressure state of the system. This built-in feature of modern
browsers further improves the effectiveness of the break calibration
mitigation.
</div>
</aside>
</section>
<section>
<h4>Break calibration parameters</h4>
<p><i>This section is non-normative.</i></p>
<p>
Based on implementation experience, implementers are advised to apply the mitigation
to a randomized time value within a range between 120000 milliseconds (2minutes) and 240000 milliseconds (4 minutes).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
to a randomized time value within a range between 120000 milliseconds (2minutes) and 240000 milliseconds (4 minutes).
to a randomized time value within a range between 120000 milliseconds (2 minutes) and 240000 milliseconds (4 minutes).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ll make the change in my commit. easier

</p>
<p>
These values are subject to change and are updated based on further implementation experience and research findings.
</p>
</section>
<section>
<h4>Same-origin restriction</h4>
Expand Down
Loading