Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Organization and Groups info to index file #322

Merged
merged 11 commits into from
Jul 1, 2021
Merged

Add Organization and Groups info to index file #322

merged 11 commits into from
Jul 1, 2021

Conversation

tidoust
Copy link
Member

@tidoust tidoust commented Jun 30, 2021

This fetches some info about the organization and groups that own each spec, adding an organization property and a groups property.

Info for WHATWG, TC39, and WebGL specs is hardcoded. Info for W3C specs gets fetched from the W3C API for /TR specs and from the w3c.json file in repos (and then from the W3C API) otherwise.

Closes #32

Draft PR because README still needs to be updated.

@tidoust
Add Organization and Groups info to index file
a88a6bc 
This fetches some info about the organization and groups that own each spec,
adding an `organization` property and a `groups` property.

Info for WHATWG, TC39, and WebGL specs is hardcoded. Info for W3C specs gets
fetched from the W3C API for /TR specs and from the w3c.json file in repos (and
then from the W3C API) otherwise.

Closes #32
dontcallmedom
dontcallmedom reviewed Jul 1, 2021
View reviewed changes
src/fetch-groups.js Outdated Show resolved Hide resolved
dontcallmedom
dontcallmedom reviewed Jul 1, 2021
View reviewed changes
src/fetch-groups.js Outdated Show resolved Hide resolved
dontcallmedom
dontcallmedom reviewed Jul 1, 2021
View reviewed changes
src/fetch-groups.js Outdated Show resolved Hide resolved
dontcallmedom
dontcallmedom reviewed Jul 1, 2021
View reviewed changes
index.json Outdated Show resolved Hide resolved
@tidoust tidoust marked this pull request as ready for review July 1, 2021 15:32
@tidoust
Copy link
Member Author

tidoust commented Jul 1, 2021

I'm a bit at a loss as to why CI fails. It complains that the organization property is missing on one of the specs but, as far as I can tell, all specs have that property in the version of index.json I pushed with the PR, tests pass locally (and I didn't forget any file for once).

dontcallmedom
dontcallmedom approved these changes Jul 1, 2021
View reviewed changes
Copy link
Member

@dontcallmedom dontcallmedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand nor can reproduce the CI failure either 🤷

@dontcallmedom
Copy link
Member

maybe bump the package minor version while we're at it? (new feature)

@dontcallmedom
Copy link
Member

hmm.. or is a schema change a major version bump?

@tidoust
Copy link
Member Author

tidoust commented Jul 1, 2021

Our versioning rules suggest that a major version bump is not needed since this does not introduce a backwards-incompatible change.

Note that version bumps are done when I release a new version (for instance, I just released a v1.42.0 with the new specs), so not something that need to be done in the PR.

@tidoust
Copy link
Member Author

tidoust commented Jul 1, 2021

Merging with master solved the CI issue. No idea why...

@tidoust tidoust merged commit a63eddb into master Jul 1, 2021
@tidoust tidoust deleted the groups branch July 1, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontcallmedom dontcallmedom dontcallmedom approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Consider exposing the group/organization that owns the spec
2 participants
@tidoust @dontcallmedom