Expose spec repository in nightly.repository #105
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See w3c#19. The repository is either retrieved from Specref or computed from the nightly URL.
There was a problem hiding this comment.
I script-checked the following:
- each repo listed in index.json appears in validate-repo (to make sure we haven't missed potential renames) - with the caveat that validate-repo doesn't cover whatwg, Khronos, webbluetoothcg and webidl
- each drafts.csswg.org spec has an associated directory in w3c/csswg-drafts (which is only true if you also add the version number to the nightly url)
I detected one bug (trailing / in repo URL) and one likely needed improvement (case of the github org name)
tidoust
changed the title
index.json
Outdated
| @@ -1056,7 +1056,7 @@ | |||
| }, | |||
| "nightly": { | |||
| "url": "https://wicg.github.io/frame-timing/", | |||
| "repository": "https://github.com/w3c/frame-timing" | |||
| "repository": "https://github.com/wicg/frame-timing" | |||
There was a problem hiding this comment.
ha, this uncovered another bug - I guess in my check of repo existence, I should have checked they were not archived either
dontcallmedom
approved these changes
Jun 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #19. The repository is either retrieved from Specref or computed from the nightly URL.