Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New specs for review #308

Closed
1 task
github-actions bot opened this issue Jun 7, 2021 · 4 comments
Closed
1 task

New specs for review #308

github-actions bot opened this issue Jun 7, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@github-actions
Copy link
Contributor

github-actions bot commented Jun 7, 2021

find-specs has identified the following candidates as potential new specs to consider:

Please review if they match the inclusion criteria. Those that don't and never will should be added to ignore.json, those that don't match yet but may in the future can be added to monitor-repo.json, and those that do match should be brought as a pull request on specs.json.

@github-actions github-actions bot added the enhancement New feature or request label Jun 7, 2021
@sideshowbarker
Copy link
Member

Seems to be a duplicate of part of #303 (fixed in 726b508).

@tidoust
Copy link
Member

tidoust commented Jun 7, 2021

Indeed, the URL bugs the job that looks for TC39 Stage 3 proposals because the URL in the list of proposals uses https://github.com/tc39-transfer instead of https://github.com/tc39.

We should either add the URL to the ignore list or complete the logic to handle tc39-transfer URLs, otherwise we're going to get a new report every week...

@dontcallmedom
Copy link
Member

I've filed tc39/proposals#358 to fix the url upstream - from what I understand, tc39-transfer is not expected to be a stable url

@ljharb
Copy link
Member

ljharb commented Jun 7, 2021

Github redirects these URLs, so the proper solution is for the job to follow redirects.

It will quite often be the case that a URL in the proposals repo isn't the final one, but redirects to the final one, which is Just Fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants