Skip to content

Commit

Permalink
Relax test on repository for IETF specs (#1124)
Browse files Browse the repository at this point in the history
The test expected all IETF entries to have an rfc-editor URL. That's not
the case for IETF specs that have not yet been published as RFC. The
test now simply ignores all specs associated with IETF to avoid returning
false positives.
  • Loading branch information
tidoust authored Nov 13, 2023
1 parent 5b403bd commit ed05645
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -151,21 +151,21 @@ describe("List of specs", () => {
assert.deepStrictEqual(wrong, []);
});

it("contains repository URLs for all non IETF specs", () => {
it("contains repository URLs for all specs save a restricted set", () => {
// Some more exceptions to the rule
const wrong = specs.filter(s => !s.nightly.repository &&
!s.nightly.url.match(/rfc-editor\.org/) &&
s.organization !== 'IETF' &&
!s.nightly.url.match(/\/Consortium\/Patent-Policy\/$/) &&
!s.nightly.url.match(/\/sourcemaps\.info\//) &&
!s.nightly.url.match(/fidoalliance\.org\//) &&
!noRepo.includes(s.shortname));
assert.deepStrictEqual(wrong, []);
});

it("contains relative paths to source of nightly spec for all non IETF specs", () => {
it("contains relative paths to source of nightly spec for all specs save a restricted set", () => {
// Some more exceptions to the rule
const wrong = specs.filter(s => !s.nightly.sourcePath &&
!s.nightly.url.match(/rfc-editor\.org/) &&
s.organization !== 'IETF' &&
!s.nightly.url.match(/\/Consortium\/Patent-Policy\/$/) &&
!s.nightly.url.match(/tc39\.es\/proposal\-decorators\/$/) &&
!s.nightly.url.match(/\/sourcemaps\.info\//) &&
Expand Down

0 comments on commit ed05645

Please sign in to comment.