Improve a11y by providing explicit descriptive headers for enums. #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alastor0325
requested review from
chrisn and
tidoust
and removed request for
chrisn
|
Hmm I did something wrong, I need to separate the |
chrisn
approved these changes
Sep 13, 2022
|
Sorry, I messed up my local branch a little bit, which causes some unnecessary commits. But the final result is correct and fixed the build error. |
github-actions bot
added a commit
that referenced
this pull request
Sep 15, 2022
SHA: 04cbd85 Reason: push, by @alastor0325 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #32 (comment).