Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error in "Commit history" link #119

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

RensOliemans
Copy link

@RensOliemans RensOliemans commented Oct 2, 2023

The "Commit history" link of the recommendation (current version at https://www.w3.org/TR/2020/REC-audiobooks-20201110/) points to https://github.com/w3c/audiobooks/commits/master. However, the 'main' branch is used instead of 'master', so this link 404s.

This is my first time looking at these specifications, I am not sure if this commit actually fixes the issue at hand.


Preview | Diff

The "Commit history" link of the recommendation (current version at
https://www.w3.org/TR/2020/REC-audiobooks-20201110/) points to
https://github.com/w3c/audiobooks/commits/master. However, the 'main'
branch is used instead of 'master', so this link 404s.
@RensOliemans
Copy link
Author

RensOliemans commented Oct 2, 2023

I believe that the PR is non-substantial, so no affiliation is necessary—I did not yet have a W3C account. I have since created one and linked it to my GitHub account. I have no affiliation to any company. I am a student, but this change is unrelated to my study or university.
Is it necessary to enter my affiliation with my university?

@w3cbot
Copy link

w3cbot commented Oct 2, 2023

iherman marked as non substantive for IPR from ash-nazg.

@iherman iherman requested review from iherman and wareid October 2, 2023 08:56
@iherman
Copy link
Member

iherman commented Oct 2, 2023

Thank you, @RensOliemans, the change you propose indeed fixes this, and the change is also non-substantive (and I have set it as such), so you can ignore the corresponding automatic mails.

Cc @wareid @mattgarrish

iherman added a commit to w3c/pub-manifest that referenced this pull request Oct 2, 2023
iherman added a commit to w3c/pub-manifest that referenced this pull request Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants