Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating TOC section to reflect changes #112

Closed
wants to merge 6 commits into from
Closed

Updating TOC section to reflect changes #112

wants to merge 6 commits into from

Conversation

wareid
Copy link
Contributor

@wareid wareid commented Feb 16, 2022

To better reflect the importance of the TOC in light of the change in PR #111 and issue #110, I am updating the language in the TOC section, and adding a note. This is to clarify that in the event of audio files containing more than one chapter/section, the TOC should be used to display that granularity.

Feel free to offer editorial advice, it is much needed.

There were some (temporary) problems with Preview, so it could not work on this PR. Here is a preview/diff pair; it is slow but can help to review this:


Preview | Diff

order</a>.</p>

<div class="proposed correction">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a separate PR (#113) to handle these types of normative changes.

starting and ending points of those chapters in the larger audio file, as demonstrated in <a
href="#toc-mediafragments">this example</a>.</p>

<div class="proposed correction">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, see #113

@wareid
Copy link
Contributor Author

wareid commented Feb 22, 2022

Closing this to fix my branching mistake. New PR with just this change incoming.

@wareid wareid closed this Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants