[html-aam PR 529] Addition: Name from heading #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #457 Related to the following: - #1860 - w3c/accname#229 (this needs to be merged so the new links to 'accName: name from heading' will work
Co-authored-by: James Craig <[email protected]>
Co-authored-by: James Craig <[email protected]>
per @cookiecrook review, changing a couple more instances where 'accessible name' should be used instead of 'subtree'
21 tasks
pkra
changed the title
1 task
|
Re-assigning reviewers @cookiecrook @spectranaut for this migrated html-aam PR. |
spectranaut
reviewed
Aug 13, 2024
There was a problem hiding this comment.
The text looks good to me. @cookiecrook @scottaohara I wonder if these changes should be moved to the main PR: #1860 -- since it is related to the implementation and should land at the same time?
That is the goal of the mono repo, less PRs when there are dependent changes across specs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved from w3c/html-aam#529
Adds name from heading computation steps for
<article>and<dialog>