-
Notifications
You must be signed in to change notification settings - Fork 125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update figure role #1705
update figure role #1705
Conversation
This PR requires #1703 be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that aria-label and aria-labelledby can be used to label a figure element
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, and editorial looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Approved the related PR as well. 👍
@smhigley is this one ok by you now? |
@scottaohara would you be able to resolve the merge conflicts? |
@pkra done |
* update figure role This PR requires #1703 be merged. * Update index.html * revisions per sarah's review * further updates to figure def
* update figure role This PR requires #1703 be merged. * Update index.html * revisions per sarah's review * further updates to figure def
This PR requires #1703 be merged.
Preview | Diff