Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include mention of figure/caption #1704

Merged
merged 3 commits into from
Apr 29, 2022
Merged

include mention of figure/caption #1704

merged 3 commits into from
Apr 29, 2022

Conversation

scottaohara
Copy link
Member

@scottaohara scottaohara commented Mar 12, 2022

this pr updates aria-details to mention figure and figcaption.

This update is related to HTML AAM's update to the figure and figcaption elements - w3c/html-aam#359.
It is a follow on to my other PR, #1703 which updates the caption role and includes information about aria-details.


Preview | Diff

this pr updates `aria-details` to mention `figure` and `figcaption`.

This update is related to HTML AAM's update to the `figure` and `figcaption` elements - w3c/html-aam#359.
It is a follow on to my other PR, #1703 which updates the `caption` role and includes information about `aria-details`.
Copy link
Contributor

@chlane chlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with aria-details referencing captions

Copy link
Contributor

@charmarkk charmarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, and editorial looks good (once "within" has its H).

index.html Outdated Show resolved Hide resolved
index.html Outdated Show resolved Hide resolved
@scottaohara scottaohara requested a review from charmarkk April 1, 2022 17:23
Copy link
Contributor

@charmarkk charmarkk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @scottaohara 😊

index.html Outdated Show resolved Hide resolved
Co-authored-by: Sarah Higley <[email protected]>
Copy link
Contributor

@MelSumner MelSumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@scottaohara
Copy link
Member Author

@pkra can this be merged as well, per the other related caption PRs I made that were merged earlier today?

thanks!

@pkra pkra added this to the ARIA 1.3 milestone Apr 29, 2022
@pkra pkra self-assigned this Apr 29, 2022
@pkra pkra merged commit 2ece5c5 into main Apr 29, 2022
@pkra pkra deleted the aria-details-figure-update branch April 29, 2022 14:12
github-actions bot added a commit that referenced this pull request Apr 29, 2022
SHA: 2ece5c5
Reason: push, by @pkra

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
jnurthen pushed a commit that referenced this pull request Oct 10, 2023
* include mention of figure/caption 

this pr updates `aria-details` to mention `figure` and `figcaption`.

This update is related to HTML AAM's update to the `figure` and `figcaption` elements - w3c/html-aam#359. 

It is a follow on to my other PR, #1703 which updates the `caption` role and includes information about `aria-details`.

Co-authored-by: Sarah Higley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants