fix Children Pres. for math #1172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to section 7.1, math is intended to have children presentational: True This PR fixes this.
scottaohara
approved these changes
Jan 25, 2020
|
Heh, #425 reads like a suspense novel... will math children be presentational... or not? Of course, I already know the ending, but I read the story anyhow so that I could follow the plot twists. 😄 So, I've updated the list of roles with children presentational in 7.1 to remove This PR (#1172) can serve as the corresponding "issue" to update the list of roles in 7.1. |
|
Lets close this one then |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to section 7.1, math is intended to have "children presentational: True". This PR fixes that. Alternatively, 7.1 could be updated, but this seemed like the right way this was supposed to work.
Preview | Diff