-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Are section elements in examples intended to be landmarks? #562
Comments
Change-Id: I790cb1f9631c6d646c25695fbfd04efd390215a5 Signed-off-by: Carolyn MacLeod <[email protected]>
@carmacleod commented:
Not for the sections inside of main.
The purpose of landmarks is not to represent the information architecture of a document. Doing so causes proliferation that reduces the value of landmarks. Headings are the best way of making IA accessible.
Sections with labels are landmarks and sections that do not have labels are not landmarks. That was one of the intents of the ARIA 1.1 restructuring of the landmark portion of the ontology. To the best of my knowledge, it is not inappropriate to have unlabeled sections. I'd rather not change the sections to divs unless there really is some conformance reason to do so. |
@carmacleod, closing as answered. Please feel free to re-open if the resolution is not satisfactory. |
Hi @mcking65. Thanks for your feedback. I can't reopen, but I do have further comments. The HTML spec for section element says that the default role for section is
The HTML spec even has an example of section elements that have an aria-label. The ARIA spec for region contains the following paragraph:
Taken together, the HTML spec and the ARIA spec seem to say, "sections must have explicit labels". |
Hi @mcking65 - any comment on my comment? |
I'm not certain if the APG example pages intend to use ARIA landmarks or not.
For example, the Data Grid page: http://w3c.github.io/aria-practices/examples/grid/dataGrids.html
has 8
<section>
elements that are not given an explicit label, therefore they are not recognized as landmarks by any screen reader that I tried (JAWS/Chrome/FF, NVDA/Chrome, VoiceOver/Safari).To be recognized as landmarks, they need either an aria-labelledby or an aria-label.
Unfortunately, at this time, just having a heading child is not good enough to be recognized as a landmark. I don't know if the broken outline algorithm is the cause of this, but I suspect so.
So the 8 section elements on the Data Grids Example page would need to have aria-labelledby pointing to their heading child. I will submit a PR so that you can see what I mean.
I personally think these sections should be landmarks - it makes sense. However if that was not the intent, then they should be switched to divs instead of keeping as unlabelled sections.
The text was updated successfully, but these errors were encountered: