Generate html source script to support aria-at-app #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✔️ Deploy Preview for aria-at ready! 🔨 Explore the source changes: e76b7e0 🔍 Inspect the deploy log: https://app.netlify.com/sites/aria-at/deploys/62325ec3eb1e650009092cee 😎 Browse the preview: https://deploy-preview-646--aria-at.netlify.app/ |
alflennik
approved these changes
Mar 17, 2022
There was a problem hiding this comment.
I'll definitely be curious if these can be removed in the future, but based on our discussion I think this is a super clean solution, and still allows us to delete hundreds of thousands of lines of generated files from the repo. And these files are way less volatile and will rarely, if ever, change. Thanks for getting us through that huge forward leap Howard!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
https://github.com/w3c/aria-at-app's TestRenderer depends on test example html artifacts which contains scripts. This previously existed in the
buildfolder, now removed by #621. This PR adds those required artifacts without the need to commit the build folder.npm run buildalready creates these files in the (now, local) build folder. They're copied over to the source folder location of the example, ie.tests/<testplan>/reference/<path>/<testplan>.<script>.html.These files are updated by:
npm run buildbefore commit and push, ORGenerate and commit filesworkflow runsnpm run build, and has had the language updated to reflect the change. (This will not run if there are no updated files and it will not cause unintended merge conflicts through clashing generated files as previously experienced; line endings for those files are ignored to help ensure this)npm run buildwill also remove the html script artifacts which are no longer being generated (most likely due to script being removed fromtests/<testplan>/data/js/<script>.jscc @s3ththompson @richnoah