Address missing review page information #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alflennik
approved these changes
Feb 14, 2022
There was a problem hiding this comment.
When reviewing this PR we had some trouble due to the fact that GitHack was down. Hopefully this issue isn't too persistent or we might need to look into using another proxy, perhaps the one ARIA-AT App provides. Fortunately we were able to work around it and confirm that the fix is working. Thanks for setting up a fake test plan PR, making it easy to confirm the fix.
howard-e
force-pushed
the
bocoup/fix-issue-597
branch
from
5b23a89 to
9dbf83b
Compare
…tory and using source branch of PR for ref
howard-e
force-pushed
the
bocoup/fix-issue-597
branch
from
428ec6c to
b468448
Compare
jesdaigle
approved these changes
Mar 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
Address #597.
The
generate-and-commit-filesstep was incorrectly referencing the master branch's head rather than the submitted PR's head.Additionally, the commit history was defaulted to a depth of 1 so the "Commit of Last Change" was duplicated across all test plans rows which made that value wrong for most.
See example preview link from test PR where
alert-testis a newly created test plan from my fork.