Add title reference field to each test plan #521
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscholes
reviewed
Oct 5, 2021
| @@ -1,6 +1,7 @@ | |||
| refId,value | |||
| author,Isabel Del Castillo | |||
| authorEmail,[email protected] | |||
| title,Action Menu Button Example | |||
There was a problem hiding this comment.
This should be "Action Menu Button Example Using element.focus()"
jscholes
reviewed
Oct 5, 2021
| @@ -1,8 +1,9 @@ | |||
| refId,value | |||
| author,Isabel Del Castillo | |||
| authorEmail,[email protected] | |||
| title,Data Grid Example | |||
There was a problem hiding this comment.
This should use the title in the corresponding issue (#352) because there are multiple data grids on the example page and they will ultimately all have a test plan.
jscholes
reviewed
Oct 5, 2021
| @@ -1,8 +1,9 @@ | |||
| refId,value | |||
| author,Isabel Del Castillo | |||
| authorEmail,[email protected] | |||
| title,Toggle Button with aria-pressed | |||
There was a problem hiding this comment.
I don't think aria-pressed is necessary here. Just "Toggle Button".
jscholes
requested changes
Oct 5, 2021
There was a problem hiding this comment.
@mzgoddard Thanks for doing this! I left some individual line comments.
mzgoddard
force-pushed
the
bocoup/test-plan-title
branch
from
8dc4476 to
0ab4872
Compare
|
Changes pushed. Thanks for the review @jscholes. |
s3ththompson
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
#473 move titles for each test plan from support.json into their references.csv.
This PR adds a tittle to test plans that did not have one.