Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create updated tests for APG design pattern example: Toggle Button #408

Merged
merged 24 commits into from
Jul 22, 2021

Conversation

IsaDC
Copy link
Contributor

@IsaDC IsaDC commented Mar 29, 2021

Preview Tests

Resolves #396.

@jscholes jscholes marked this pull request as ready for review April 2, 2021 21:02
@jscholes jscholes marked this pull request as draft April 2, 2021 21:03
@jscholes
Copy link
Contributor

jscholes commented Apr 2, 2021

@IsaDC Please review and remove draft status when you're happy with it. I can't formally request a review from the PR author 🤦‍♂️

@IsaDC IsaDC marked this pull request as ready for review April 6, 2021 16:59
@jscholes jscholes marked this pull request as draft April 8, 2021 00:02
@jscholes
Copy link
Contributor

jscholes commented Apr 8, 2021

@IsaDC I fixed the backslashes in references.csv, and re-marked this as draft. Please review the test page functionality and setup scripts.

@jscholes
Copy link
Contributor

jscholes commented Jun 8, 2021

@zcorpan Thanks for the feedback, we'll get it addressed. The community group recommendation is to provide standard comments on the PR referencing test numbers manually, rather than line-by-line comments on the diff. They are far easier to read with a screen reader, particularly given that CSV records are long and the individual problem just ends up buried somewhere within one. If you could please follow that in future, that would be great 👍

@jscholes jscholes marked this pull request as ready for review June 8, 2021 15:31
@jscholes jscholes marked this pull request as draft June 8, 2021 15:33
@jscholes
Copy link
Contributor

jscholes commented Jun 8, 2021

@IsaDC When INS_TAB is fixed, please review the setup script functionality and then mark as ready to review.

@IsaDC IsaDC marked this pull request as ready for review June 8, 2021 16:37
@zcorpan
Copy link
Member

zcorpan commented Jun 9, 2021

@jscholes noted, thanks!

howard-e and others added 3 commits July 21, 2021 22:49
# Conflicts:
#	build/index.html
#	review/checkbox-tri-state.html
#	review/checkbox.html
#	review/combobox-autocomplete-both.html
#	review/combobox-select-only.html
#	review/menu-button-actions-active-descendant.html
#	review/menubar-editor.html
#	review/modal-dialog.html
#	review/tabs-manual-activation.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create updated tests for APG design pattern example: Toggle Button
4 participants