-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create updated tests for APG design pattern example: Toggle Button #408
Conversation
…l as 'Accessibility Features', 'Keyboard Support', 'Role, Property, State, and Tabindex Attributes' and source code sections and footer nav
Note: the button has and preceding text has been hidden via `display: none` and `tabindex='-1'`, because removing it causes errors in the JavaScript for the example.
@IsaDC Please review and remove draft status when you're happy with it. I can't formally request a review from the PR author 🤦♂️ |
@IsaDC I fixed the backslashes in |
@zcorpan Thanks for the feedback, we'll get it addressed. The community group recommendation is to provide standard comments on the PR referencing test numbers manually, rather than line-by-line comments on the diff. They are far easier to read with a screen reader, particularly given that CSV records are long and the individual problem just ends up buried somewhere within one. If you could please follow that in future, that would be great 👍 |
@IsaDC When INS_TAB is fixed, please review the setup script functionality and then mark as ready to review. |
@jscholes noted, thanks! |
# Conflicts: # build/index.html # review/checkbox-tri-state.html # review/checkbox.html # review/combobox-autocomplete-both.html # review/combobox-select-only.html # review/menu-button-actions-active-descendant.html # review/menubar-editor.html # review/modal-dialog.html # review/tabs-manual-activation.html
Preview Tests
Resolves #396.