Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update scripts to only check first file and save last edited date fro… #359

Closed
wants to merge 2 commits into from

Conversation

dawnwages
Copy link

@dawnwages dawnwages commented Dec 17, 2020

Preview Tests

…m important files == git log from data and reference dirs

The code could be a little cleaner but I was able to get the optimal case complete instead of the the test.csv
https://app.asana.com/0/1193055321453706/1199152269152973/f

More notes on the ticket requirements:

  • only the data and reference folders but - git log
  • last file was changed ==> Any file in relevant directory related files
  • once for every test
  • can you check all of the underlying file, then just check test.csv and add a "~"
  • alternative: instead of checking if the test file is changed, the most relevant stuff is in test.csv

…m important files == git log from data and reference dirs
@dawnwages
Copy link
Author

better/future solution: for each important dir in list, push lastDirEdited date to array, then pick latest date as lastEdited
short on time, but happy to go back and update code to the above ^

@dawnwages
Copy link
Author

dawnwages commented Dec 17, 2020

npm run review-tests as a reminder :)

-        <li>Lasted edited: Thu Dec 10 10:41:01 2020 -0800</li>
+        <li>Last edited: ~ Wed Dec 02 2020 19:02:40 GMT-0500 (Eastern Standard Time)</li>

@s3ththompson
Copy link
Member

Superseded by #451

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants