-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add aria practice guide links to reference.csv(s) #351
Conversation
@evmiguel I'm not sure I understand the intent behind/utility of this. Using the checkbox tests as an example, there is an "example" row with the URL: https://w3c.github.io/aria-practices/#checkbox. But this is wrong; that URL is the link to the design pattern in the APG, not the example being tested. Therefore, during development of new pattern tests, we've been using that row for the actual example link, the one that in this PR is called "practiceGuide". In other words:
Let me know your thoughts. |
@jscholes Thank you for taking a look at this. We need both the |
@evmiguel - This looks good can you update the "How to write tests" to add this as a Also, @jscholes wanted to make sure you are aware that we are adding another field to the list of fields that should be added the the This change is being made to enable us to grab that data and display it in a new aria-at-app reports page. |
Understood, thanks for the additional context. The changes in |
@jscholes I noticed that, and I changed it! |
@@ -1,7 +1,8 @@ | |||
refId,value | |||
author,Michael Fairchild | |||
authorEmail,[email protected] | |||
reference,reference/2020-11-23_175030/checkbox-1/checkbox-1.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@evmiguel - There is an actual problem you seem to have lost my changes because I think you need to rebase. This needs to not change.
@@ -1,8 +1,9 @@ | |||
refId,value | |||
author,Jon Gunderson | |||
authorEmail, [email protected] | |||
reference,reference/2020-11-23_175528/menubar-editor.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same problem.
Also, in
|
bf5d44e
to
0ca37d6
Compare
0ca37d6
to
52b50fd
Compare
Preview Tests