Create tests for APG design pattern example: Select-Only Combobox #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jscholes
force-pushed
the
tests/combobox-select-only
branch
from
66eadb8 to
af45067
Compare
IsaDC
approved these changes
Nov 23, 2020
… navigating to the combobox) may need to be pressed multiple times.
…ting to the combobox
…he combobox and listbox popup
…out the listbox popup; it's not reasonable to assert that a screen reader should communicate anything about the containing listbox when a user has only asked for the text of the current option
…out the combobox in interaction mode, as unlike in reading mode, only the text of the selected option is reported
jscholes
force-pushed
the
tests/combobox-select-only
branch
from
a5eba54 to
c0bc7d0
Compare
|
Review note: the example in the reference directory isn't timestamped, because the script and pattern for this were added later than this PR (in 4d77ba2). This can easily be fixed by merging master into this tests branch, adding the timestamped directory and then allowing the test pages to be regenerated. But there are currently merge conflicts in files that haven't been manually touched during creation of this PR, such as the unrelated menubar editor tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview Tests
Resolves #331.