Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update collection form to capture severity and additional details on an unexpected behavior happening #1006

Closed
wants to merge 71 commits into from
Closed

Update collection form to capture severity and additional details on an unexpected behavior happening #1006

wants to merge 71 commits into from

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Nov 29, 2023 •
edited by github-actions bot
Loading

Preview Tests

This is additional work to support w3c/aria-at-app#738.

Modify the results collection form so that each behavior in the list of problematic behaviors has the following inputs:

  • A checkbox to indicate if the behavior occurred.
  • A select labeled "Impact" with values Moderate, and High. It is disabled if the checkbox is not checked and required if it is checked.
  • A text field labeled "Details" that is disabled if the checkbox is not checked and required if it is checked.

@howard-e howard-e requested review from stalgiag and alflennik and removed request for alflennik and stalgiag November 29, 2023 20:24
@howard-e howard-e mentioned this pull request Nov 29, 2023
Merged
3 tasks
Base automatically changed from build-v2-test-format to master November 30, 2023 17:37
@howard-e
WIP: Building test index page
5f23197
@howard-e
Adding additional TODOs to be covered; start to addressing review page
4fb8f6d
@howard-e
Fix references after rebase
e4ba708
@howard-e
Add additional data validations
7ac2a3c
@howard-e
Use MUST/SHOULD/MAY on review page
cfc1148
@howard-e
Update validations
fd33a3f
@howard-e
Now accounting for modeless ATs
a7e989a
@howard-e
Additional validations
fc17417
@howard-e
Accounting for assertionExceptions
78951f7
@howard-e
Additional validations and accounting for assertionExceptions; review…
c8cab05 
… page format now also matches 977
@howard-e
Keys handling in test-io-format.mjs
79b02b0
@howard-e
Update support.json
0e9442c
@howard-e
Remove 'v2-made' files
421191a
@howard-e
Change 'NA' for modeless to 'defaultMode'
8daee6e
@howard-e
Format .mjs files
ca3c310
@howard-e
Fix lines in keys.mjs
c54e4ab
@howard-e
Remove create-example-tests2
15b5c04
@howard-e
Revert keys.mjs quotations
04ac629
@howard-e
assertionTokens replacement
3974ede
@howard-e
show replaced assertion tokens in reviewed tests
afe97b3
@howard-e
Conditionally show modeInstructions
fa17c5c
@howard-e
testing
c6728de
@howard-e
Set mode for commandInfo
94e3258
@howard-e
Better support for modeless in aria-at-test-io-format.mjs and aria-at…
b2ac9bd 
…-test-run.mjs
stalgiag and others added 23 commits November 30, 2023 12:43
@stalgiag @howard-e
Fix issues with Delete command validation
1ae1e47
@howard-e
Remove unused function
cf486aa
@howard-e
Ensure rows in *-commands.csv are maintained by the presentationNumber
df37e8b
@howard-e
Fix case where titles and instructions were still unexpectedly refere…
4be4f4e 
…ncing reading and interactions modes in v2maker script. This work has been duplicated in #990
@howard-e
Fix review page to stop using generated commandPresentationNumbers
4c50d2e
@howard-e
Update aria-at-test-run.mjs to drop support for generated command seq…
a50bc9a 
…uence numbers
@howard-e
Better support of 0-level assertion exceptions on review page
05328e1
@howard-e
Fix linter
0e6bd52
@howard-e
Remove 'modes' from v2 test file names
68f4a9b
@howard-e
Remove comment
c796d8f
@howard-e
Add mode to individual *.collected.(json|html) files
a68c1a3
@howard-e
Fix '1 test's'' editorial error on review page
7f1ba6b
@howard-e
Fix for presenting .collected.html when needed
a0f088a
@howard-e
Add support for multiple settings with .collected
7d9c831
@howard-e
Don't show assertionPhrase column on review page for v1 build
558caaf
@howard-e
Fix when commandListSettingsPreface gets appended
a927e0f
@howard-e
Change from {at}-{settings} .collected files to a single {at} .collec…
e760aff 
…ted file which covers all settings
@howard-e
Fix combined .collected.(json|logic)
e8e7d1f
@stalgiag @howard-e
Update results collection form to support pass/fail assertion verdicts (
b5832f7 
#1003)

* Initial rendering pass

* Initial interaction with assertion checkbox

* Cleanup and use assertionResponseQuestion

* Remove unused required validation, Ensure input fires state change event

* Use assertionResponseQuestion in v1 tests as well
@howard-e
Update harness related files to support capturing of undesirable beha…
12cb2f3 
…vior's impact and additional details
@howard-e
Include severity in state
38e58c1
@howard-e
Add severity map
cd23609
@howard-e
Update additional references to otherUnexpectedBehaviorText
1c894e9
@howard-e howard-e changed the base branch from master to build-v2-test-format-with-new-csvs December 7, 2023 21:16
@howard-e howard-e changed the base branch from build-v2-test-format-with-new-csvs to master December 7, 2023 21:16
@howard-e howard-e mentioned this pull request Dec 7, 2023
Merged
@howard-e
Copy link
Contributor Author

howard-e commented Dec 7, 2023

Superseded by #1016

@howard-e howard-e closed this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@howard-e @stalgiag