Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

npm run build doesn't create build directory, fails if it doesn't exist #588

Closed
jscholes opened this issue Jan 3, 2022 · 0 comments · Fixed by #606
Closed

npm run build doesn't create build directory, fails if it doesn't exist #588

jscholes opened this issue Jan 3, 2022 · 0 comments · Fixed by #606
Labels
bug Something isn't working

Comments

@jscholes
Copy link
Contributor

jscholes commented Jan 3, 2022

I recently needed to run npm run cleanup, to completely remove the build directory in order to avoid merge conflicts. This worked as expected, but when subsequently running npm run build, this was the result:

> [email protected] build L:\Dropbox\Dev\aria-at
> npm run create-all-tests && npm run review-tests


> [email protected] create-all-tests L:\Dropbox\Dev\aria-at
> cross-var node scripts/create-all-tests.js --testplan=$npm_config_testplan

The destination 'build' directory does not exist.
npm ERR! code ELIFECYCLE

If a command is provided to remove the build directory before rebuilding it, it seems suboptimal that rebuilding it then doesn't work without the additional step of manually recreating the directory. Particularly because Git doesn't allow you to commit an empty directory addition by default, so it's impossible to do something like:

npm run cleanup
git add --all .
git commit -m "Remove build directory"
git push

... and have the GitHub Actions workflow actually work.

CC @s3ththompson

@jscholes jscholes added the bug Something isn't working label Jan 3, 2022
howard-e added a commit that referenced this issue Jan 11, 2022
howard-e added a commit that referenced this issue Feb 16, 2022
howard-e added a commit that referenced this issue Feb 16, 2022
…tests.js` (#606)

* fix for issue #588

* replace  with  mkdirSync option

* Generate test and review files automatically

Co-authored-by: howard-e <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant