Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy recommendedPhaseTargetDate while in same candidate review window for a test plan version #986

Merged
merged 2 commits into from
Mar 27, 2024

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Mar 26, 2024

Address latest comments in #973 (comment).


Copy link
Contributor

@gnarf gnarf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar enough with the workflow to provide a good local test that it is now working correctly, but the code seems correct and the additional comments about the window are useful.

Copy link
Contributor

@alflennik alflennik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a doozy to test! With some tweaking of my system clock I was able to verify that the target dates are preserved when deprecating a candidate test plan, and that the target dates are NOT preserved when there is no candidate test plan.

@alflennik alflennik merged commit 8244ed1 into main Mar 27, 2024
2 checks passed
@alflennik alflennik deleted the fix-issue-973 branch March 27, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In production / Completed
Development

Successfully merging this pull request may close these issues.

3 participants